Page MenuHomePhabricator

Support other llc-like tools in update_llc_test_checks.py
ClosedPublic

Authored by dsanders on Jun 1 2020, 3:19 PM.

Details

Summary

If you have downstream tools that are llc-like (e.g, llc with different
defaults), it's convenient to still be able to use
update_llc_test_checks with them. Refactor slightly to allow such tools
to be supported by adding them to LLC_LIKE_TOOLS

Diff Detail

Event Timeline

dsanders created this revision.Jun 1 2020, 3:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2020, 3:19 PM
bogner accepted this revision.Jun 1 2020, 3:22 PM

Seems straightforward enough. A couple of minor nitpicks.

llvm/utils/update_llc_test_checks.py
23–25

A comment explaining why this is a tuple of one (much like the commit message) would be helpful here.

134–135

Please stick to 80-col

This revision is now accepted and ready to land.Jun 1 2020, 3:22 PM
This revision was automatically updated to reflect the committed changes.