Support other llc-like tools in update_llc_test_checks.py

[dsanders]

Summary

If you have downstream tools that are llc-like (e.g, llc with different
defaults), it's convenient to still be able to use
update_llc_test_checks with them. Refactor slightly to allow such tools
to be supported by adding them to LLC_LIKE_TOOLS

[bogner]

Seems straightforward enough. A couple of minor nitpicks.

llvm/utils/update_llc_test_checks.py

23–25

A comment explaining why this is a tuple of one (much like the commit message) would be helpful here.

134–135

Please stick to 80-col

llvm/utils/update_llc_test_checks.py

 import string
 import subprocess
 import sys
 import re
 
 from UpdateTestChecks import asm, common
 
 ADVERT = ' NOTE: Assertions have been autogenerated by '
-
+# llc is the only llc-like in the LLVM tree but downstream forks can add
+# additional ones here if they have them.
+LLC_LIKE_TOOLS = ('llc',) 
 
 def main():
   parser = argparse.ArgumentParser(description=__doc__)
-  parser.add_argument('--llc-binary', default='llc',
+  parser.add_argument('--llc-binary', default=None,
                       help='The "llc" binary to use to generate the test case')
   parser.add_argument(
       '--function', help='The function in the test file to update')
   parser.add_argument(
       '--extra_scrub', action='store_true',
       help='Always use additional regex to further reduce diffs between various subtargets')
   parser.add_argument(
       '--x86_scrub_rip', action='store_true', default=True,
for l in run_lines:
       m = common.MARCH_ARG_RE.search(llc_cmd)
       if m:
         march_in_cmd = m.groups()[0]
 
       filecheck_cmd = ''
       if len(commands) > 1:
         filecheck_cmd = commands[1]
       common.verify_filecheck_prefixes(filecheck_cmd)
-      if llc_tool != 'llc':
+      if llc_tool not in LLC_LIKE_TOOLS:
         common.warn('Skipping non-llc RUN line: ' + l)
         continue
 
       if not filecheck_cmd.startswith('FileCheck '):
         common.warn('Skipping non-FileChecked RUN line: ' + l)
         continue
 
       llc_cmd_args = llc_cmd[len(llc_tool):].strip()
for test in test_paths:
     for p in run_list:
       prefixes = p[0]
       for prefix in prefixes:
         func_dict.update({prefix: dict()})
     for prefixes, llc_args, triple_in_cmd, march_in_cmd in run_list:
       common.debug('Extracted LLC cmd:', llc_tool, llc_args)
       common.debug('Extracted FileCheck prefixes:', str(prefixes))
 
-      raw_tool_output = common.invoke_tool(args.llc_binary, llc_args, test)
+      raw_tool_output = common.invoke_tool(args.llc_binary or llc_tool,
+                                           llc_args, test)
       triple = triple_in_cmd or triple_in_ir
       if not triple:
         triple = asm.get_triple_from_march(march_in_cmd)
 
       asm.build_function_body_dictionary_for_triple(args, raw_tool_output,
           triple, prefixes, func_dict)
 
     is_in_function = False