This is an archive of the discontinued LLVM Phabricator instance.

Differential D80808

Add DIAError.h to list of headers excluded from the LLVM_DebugInfo_PDB module
ClosedPublic

Authored by dang on May 29 2020, 8:40 AM.

Details

Reviewers
Bigcheese
aganea
rsmith
dexonsmith
Commits
rGa05f1e5ae4e0: Add DIAError.h to list of headers excluded from the LLVM_DebugInfo_PDB module

Diff Detail

Event Timeline

dang created this revision.May 29 2020, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2020, 8:40 AM
Herald added subscribers: llvm-commits, dexonsmith. · View Herald Transcript
dang added reviewers: Bigcheese, aganea, rsmith.May 29 2020, 8:42 AM
Harbormaster failed remote builds in B58438: Diff 267259!May 29 2020, 9:46 AM
dexonsmith accepted this revision.May 29 2020, 10:23 AM

LGTM.

This revision is now accepted and ready to land.May 29 2020, 10:23 AM
Harbormaster completed remote builds in B58438: Diff 267259.May 30 2020, 10:04 AM
dang added a comment.Jun 1 2020, 10:34 AM

Can you commit this for me?

dexonsmith added a comment.Jun 1 2020, 10:35 AM
In D80808#2066786, @dang wrote:

Can you commit this for me?

Oh, right, you don't have commit access yet. I think you should get that. Here are the instructions:
https://llvm.org/docs/DeveloperPolicy.html#new-contributors

Closed by commit rGa05f1e5ae4e0: Add DIAError.h to list of headers excluded from the LLVM_DebugInfo_PDB module (authored by dang). · Explain WhyJun 1 2020, 1:02 PM
This revision was automatically updated to reflect the committed changes.
dang added a comment.Jun 1 2020, 1:04 PM

Committed in a05f1e5ae4e0d0fc789a4caeff108fe4a50dc652

Revision Contents

PathSize
llvm/
include/
llvm/
1 line

Diff 267706

llvm/include/llvm/module.modulemap

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Linesmodule LLVM_DebugInfo_PDB {
exclude header "DebugInfo/PDB/DIA/DIAEnumDebugStreams.h" exclude header "DebugInfo/PDB/DIA/DIAEnumDebugStreams.h"
exclude header "DebugInfo/PDB/DIA/DIAEnumFrameData.h" exclude header "DebugInfo/PDB/DIA/DIAEnumFrameData.h"
exclude header "DebugInfo/PDB/DIA/DIAEnumInjectedSources.h" exclude header "DebugInfo/PDB/DIA/DIAEnumInjectedSources.h"
exclude header "DebugInfo/PDB/DIA/DIAEnumLineNumbers.h" exclude header "DebugInfo/PDB/DIA/DIAEnumLineNumbers.h"
exclude header "DebugInfo/PDB/DIA/DIAEnumSectionContribs.h" exclude header "DebugInfo/PDB/DIA/DIAEnumSectionContribs.h"
exclude header "DebugInfo/PDB/DIA/DIAEnumSourceFiles.h" exclude header "DebugInfo/PDB/DIA/DIAEnumSourceFiles.h"
exclude header "DebugInfo/PDB/DIA/DIAEnumSymbols.h" exclude header "DebugInfo/PDB/DIA/DIAEnumSymbols.h"
exclude header "DebugInfo/PDB/DIA/DIAEnumTables.h" exclude header "DebugInfo/PDB/DIA/DIAEnumTables.h"
exclude header "DebugInfo/PDB/DIA/DIAError.h"
exclude header "DebugInfo/PDB/DIA/DIAFrameData.h" exclude header "DebugInfo/PDB/DIA/DIAFrameData.h"
exclude header "DebugInfo/PDB/DIA/DIAInjectedSource.h" exclude header "DebugInfo/PDB/DIA/DIAInjectedSource.h"
exclude header "DebugInfo/PDB/DIA/DIALineNumber.h" exclude header "DebugInfo/PDB/DIA/DIALineNumber.h"
exclude header "DebugInfo/PDB/DIA/DIARawSymbol.h" exclude header "DebugInfo/PDB/DIA/DIARawSymbol.h"
exclude header "DebugInfo/PDB/DIA/DIASectionContrib.h" exclude header "DebugInfo/PDB/DIA/DIASectionContrib.h"
exclude header "DebugInfo/PDB/DIA/DIASession.h" exclude header "DebugInfo/PDB/DIA/DIASession.h"
exclude header "DebugInfo/PDB/DIA/DIASourceFile.h" exclude header "DebugInfo/PDB/DIA/DIASourceFile.h"
exclude header "DebugInfo/PDB/DIA/DIASupport.h" exclude header "DebugInfo/PDB/DIA/DIASupport.h"
▲ Show 20 Lines • Show All 294 Lines • Show Last 20 Lines