This is an archive of the discontinued LLVM Phabricator instance.

Differential D80645

[sanitizer] check for file before linting
AcceptedPublic

Authored by rksharma on May 27 2020, 10:11 AM.

Details

Reviewers
vitalybuka
cryptoad
Summary

This patch checks for files before passing them to cpplint to avoid cpplint failure which occurs when it is ran without any file. During the build, this happens when it tries to lint inc files and ends up finding nothing. It may not be the exact fix to that situation but it is good to have a check.

Diff Detail

Unit TestsFailed

TimeTest
160 mscfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
120 mscfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
110 mscfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
120 mscfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
90 mscfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
View Full Test Results (112 Failed)

Event Timeline

rksharma created this revision.May 27 2020, 10:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2020, 10:11 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster failed remote builds in B58077: Diff 266585!May 27 2020, 11:23 AM
vitalybuka accepted this revision.Jun 11 2020, 3:40 AM
This revision is now accepted and ready to land.Jun 11 2020, 3:40 AM

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
scripts/
4 lines

Diff 266585

compiler-rt/lib/sanitizer_common/scripts/check_lint.sh

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
EXITSTATUS=0 EXITSTATUS=0
ERROR_LOG=$(${MKTEMP}) ERROR_LOG=$(${MKTEMP})
run_lint() { run_lint() {
FILTER=$1 FILTER=$1
shift shift
TASK_LOG=$(${MKTEMP}) TASK_LOG=$(${MKTEMP})
if [ ! -z "$@" ]; then
${CPPLINT} --filter=${FILTER} "$@" > $TASK_LOG 2>&1 ${CPPLINT} --filter=${FILTER} "$@" > $TASK_LOG 2>&1
fi
if [ "$?" != "0" ]; then if [ "$?" != "0" ]; then
cat $TASK_LOG | grep -v "Done processing" | grep -v "Total errors found" \ cat $TASK_LOG | grep -v "Done processing" | grep -v "Total errors found" \
| grep -v "Skipping input" >> $ERROR_LOG | grep -v "Skipping input" >> $ERROR_LOG
fi fi
if [ "${SILENT}" != "1" ]; then if [ "${SILENT}" != "1" ]; then
cat $TASK_LOG cat $TASK_LOG
fi fi
${LITLINT} "$@" 2>>$ERROR_LOG ${LITLINT} "$@" 2>>$ERROR_LOG
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines