Page MenuHomePhabricator

rksharma (Reshabh Sharma)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 22 2019, 11:51 PM (73 w, 2 d)

Recent Activity

Dec 11 2020

rksharma added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

@MaskRay It seems linkerMain is okay?

Dec 11 2020, 6:40 AM · Restricted Project
rksharma updated the diff for D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

Rename LinkerDriver::link and LinkerDriver::main (in ELF) to LinkerDriver::linkerMain

Dec 11 2020, 6:38 AM · Restricted Project

Dec 3 2020

rksharma added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

I think changing from main to to avoids an issue and adds a new issue. We should fix the issues all together, and this requires consensus from others ports to proceed.

Dec 3 2020, 9:22 AM · Restricted Project
rksharma added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

This is consistent with the other drivers, LGTM.
Do you have commit access? Please ask for it if you're planning more changes in the future. Otherwise I can land it for you.

Dec 3 2020, 6:01 AM · Restricted Project
rksharma added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

Ping

Dec 3 2020, 5:16 AM · Restricted Project

Nov 19 2020

rksharma updated the diff for D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

link seems to be a more consistent name as pointed out by @MaskRay
Can we ignore its clash with lld::*::link as the general intent with setting a breakpoint at main is to trap the main function and not the lld::elf::LinkerDriver::main which may not be true for link

Nov 19 2020, 8:14 AM · Restricted Project

Nov 14 2020

rksharma added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

However I think this current patch is orthogonal to all that and simply aims to solve a gdb breakpoint issue?

Nov 14 2020, 4:22 AM · Restricted Project
rksharma added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

I am always trapped on this. In gdb both b main and b ::main set a breakpoint on lld::elf::LinkerDriver::main. For consistency, I would suggest lld::*::LinkerDriver::link which is used by COFF and wasm ports. However, that has the name collision problems with the free functions lld::*::link... (This may be less of a problem because developers don't often set breakpoints on link? :) )

Nov 14 2020, 4:20 AM · Restricted Project

Nov 13 2020

rksharma requested review of D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.
Nov 13 2020, 5:37 AM · Restricted Project

May 27 2020

rksharma created D80645: [sanitizer] check for file before linting.
May 27 2020, 10:17 AM · Restricted Project