This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Adjusts Cortex-A57 machine model to handle zero shift.
ClosedPublic

Authored by cestes on Mar 3 2015, 2:37 PM.

Details

Summary

Integer ADD and SUB instructions on Cortex-A57 have different
latencies and processor resource usage (pipeline) when they have a
shift of zero vs. non-zero. This patches uses a SchedWriteVariant
to capture both.

Diff Detail

Event Timeline

cestes updated this revision to Diff 21143.Mar 3 2015, 2:37 PM
cestes retitled this revision from to [AArch64] Adjusts Cortex-A57 machine model to handle zero shift..
cestes updated this object.
cestes edited the test plan for this revision. (Show Details)
cestes added a subscriber: Unknown Object (MLST).Mar 4 2015, 12:13 PM
jmolloy accepted this revision.Mar 16 2015, 1:02 AM
jmolloy edited edge metadata.

LGTM, as far as I can tell.

This revision is now accepted and ready to land.Mar 16 2015, 1:02 AM
apazos edited edge metadata.Apr 8 2015, 4:40 PM

I did not detect performance gain in the tests I ran (internal workload), but you are modelling is more precise now. LGTM.

mcrosier closed this revision.Apr 10 2015, 6:28 AM
mcrosier added a subscriber: mcrosier.

Committed in r234593.

Allen added a subscriber: Allen.Aug 16 2022, 7:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2022, 7:53 PM