This is an archive of the discontinued LLVM Phabricator instance.

[Mips] use correct ld.so for musl soft float
Needs ReviewPublic

Authored by joewholden on May 21 2020, 7:26 PM.

Details

Reviewers
atanasyan
Summary

This patch attempts to fix the dynamic linker path for mips64-sf, I'm not entirely familiar with the llvm structure so I am unsure if this is the best way but I'd appreciate some feedback if not

Diff Detail

Event Timeline

joewholden created this revision.May 21 2020, 7:26 PM
  1. Please include as much context as possible with your diff. This instruction helps to do that.
  2. Such patch needs test case(s). Maybe it's enough to update the linux-ld.c test case which is failed now. Update failed cases and check both "soft" and "hard" float cases in this test.

This is actually wrong anyway

This is actually wrong anyway

If it is wrong, it should be abandoned. If it is correct, can you add some tests under clang/test/Driver and test with ninja check-clang-driver?

I think this is better (we've been using it for a while successfully), I haven't had time to understand the tests enough to add some yet, but I'll take a look as soon as I can

Such driver tests are in clang/test/Driver/. You may want to read a few existing mips driver tests and musl tests to figure out whether reusing an existing file or creating a new file makes more sense.

You can run a test with $build/bin/llvm-lit -vv test.c. check-clang-driver runs all test/Driver tests. Before uploading a patch, check-clang-driver or check-clang (the latter if you suspect other components can be affected). For driver, check-clang-driver is usually sufficient.