[TestGlobalVariables] LD_LIBRARY_PATH should be process working directory.

[chaoren]

Summary

The inferior can load the library now, but the remote test is still failing
because of a module loading problem in LLDB.

[clayborg]

Please try and make self.registerSharedLibrariesWithTarget(...) do all that is needed.

lldb/trunk/test/lang/c/global_variables/TestGlobalVariables.py

34–44

You shouldn't have to do any of this if you call:

environment = self.registerSharedLibrariesWithTarget(target, self.shlib_names)

as the code in registerSharedLibrariesWithTarget there should do this. Can you look into why this is failing? We don't want platform specific code like this in any tests, it should all be in utility functions in the python files in the lldb/test directory.

[chaoren]

lldb/trunk/test/lang/c/global_variables/TestGlobalVariables.py

34–44

You're right. I'll remove that entire chunk of code. I think Oleksiy has a CL in progress that can fix remote module loading problem.

lldb/trunk/test/lang/c/global_variables/TestGlobalVariables.py

class GlobalVariablesTestCase(TestBase):
 
     def setUp(self):
         # Call super's setUp().
         TestBase.setUp(self)
         # Find the line number to break inside main().
         self.source = 'main.c'
         self.line = line_number(self.source, '// Set break point at this line.')
         self.shlib_names = ["a"]
         if sys.platform.startswith("freebsd") or sys.platform.startswith("linux"):
             # LD_LIBRARY_PATH must be set so the shared libraries are found on startup
             if "LD_LIBRARY_PATH" in os.environ:
-                self.runCmd("settings set target.env-vars " + self.dylibPath + "=" + os.environ["LD_LIBRARY_PATH"] + ":" + os.getcwd())
+                self.runCmd("settings set target.env-vars " +
+                            self.dylibPath + "=" +
+                            os.environ["LD_LIBRARY_PATH"] + ":" +
+                            self.get_process_working_directory())
             else:
-                self.runCmd("settings set target.env-vars " + self.dylibPath + "=" + os.getcwd())
+                self.runCmd("settings set target.env-vars " +
+                            self.dylibPath + "=" +
+                            self.get_process_working_directory())
             self.addTearDownHook(lambda: self.runCmd("settings remove target.env-vars " + self.dylibPath))
 
     def global_variables(self):
         """Test 'frame variable --scope --no-args' which omits args and shows scopes."""
         # Create a target by the debugger.
         target = self.dbg.CreateTarget("a.out")
         self.assertTrue(target, VALID_TARGET)