Page MenuHomePhabricator

[TestGlobalVariables] LD_LIBRARY_PATH should be process working directory.
ClosedPublic

Authored by chaoren on Mar 3 2015, 12:02 PM.

Diff Detail

Event Timeline

chaoren retitled this revision from to [TestGlobalVariables] LD_LIBRARY_PATH should be process working directory..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added a subscriber: Unknown Object (MLST).
sivachandra accepted this revision.Mar 3 2015, 12:09 PM
sivachandra edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2015, 12:09 PM
This revision was automatically updated to reflect the committed changes.
clayborg edited edge metadata.Mar 3 2015, 1:10 PM

Please try and make self.registerSharedLibrariesWithTarget(...) do all that is needed.

lldb/trunk/test/lang/c/global_variables/TestGlobalVariables.py
34–44 ↗(On Diff #21127)

You shouldn't have to do any of this if you call:

environment = self.registerSharedLibrariesWithTarget(target, self.shlib_names)

as the code in registerSharedLibrariesWithTarget there should do this. Can you look into why this is failing? We don't want platform specific code like this in any tests, it should all be in utility functions in the python files in the lldb/test directory.

chaoren added inline comments.Mar 3 2015, 2:45 PM
lldb/trunk/test/lang/c/global_variables/TestGlobalVariables.py
34–44 ↗(On Diff #21127)

You're right. I'll remove that entire chunk of code. I think Oleksiy has a CL in progress that can fix remote module loading problem.