Page MenuHomePhabricator

[CMake] Refactor the main lldb cmake file
ClosedPublic

Authored by zturner on Mar 2 2015, 11:59 AM.

Details

Reviewers
sivachandra
Summary

The existing state of affairs was getting a little unwieldy.

All of LLDB's utility functions and initial configuration was in the root CMake file. I split this up into 3 separate files and moved them to relevant subfolders under cmake/modules.

Also, I deleted the add_lldb_definitions() function. It seemed to be somewhat useless and did not serve any real purpose that I was able to figure out.

Diff Detail

Event Timeline

zturner updated this revision to Diff 21025.Mar 2 2015, 11:59 AM
zturner retitled this revision from to [CMake] Refactor the main lldb cmake file.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a reviewer: sivachandra.
zturner added a subscriber: Unknown Object (MLST).
sivachandra accepted this revision.Mar 2 2015, 12:08 PM
sivachandra edited edge metadata.

LGTM overall. You mentioned on IRC but just for the record, I am assuming you tested the changes on Linux.
Thanks for doing this.

This revision is now accepted and ready to land.Mar 2 2015, 12:08 PM

Yes, built on Linux. I didn't use any special flags, so I can't guarantee that the exact set of flags anyone uses didn't break, but I think the change is generally low risk as it's mostly just a code move. Because of the grouping into different files, a few lines get executed in different order than before, so that's the only risk as far as I can tell. But it seems to be ok.

zturner closed this revision.Mar 2 2015, 8:38 PM