Page MenuHomePhabricator

Unrank mcuMemHostRegister tensor argument.
ClosedPublic

Authored by csigg on May 18 2020, 5:13 AM.

Diff Detail

Event Timeline

csigg created this revision.May 18 2020, 5:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2020, 5:13 AM

The presubmit failure is from clang-tidy:

/mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/mlir/tools/mlir-cuda-runner/cuda-runtime-wrappers.cpp:22:10: error: 'cuda.h' file not found [clang-diagnostic-error]
#include "cuda.h"
         ^

Is there anything I can/need to do about it?

herhut accepted this revision.May 19 2020, 2:23 AM

Nice cleanup, thanks!

mlir/tools/mlir-cuda-runner/cuda-runtime-wrappers.cpp
106

This is a bit fishy, as you rely on the inner layout of the descriptor declared in a different file. It would be nicer to have an interface in that header that allows to do this.

This revision is now accepted and ready to land.May 19 2020, 2:23 AM
csigg marked 2 inline comments as done.May 19 2020, 4:57 AM
csigg added inline comments.
mlir/tools/mlir-cuda-runner/cuda-runtime-wrappers.cpp
106

Will do that in a separate change.

This revision was automatically updated to reflect the committed changes.
csigg marked an inline comment as done.