This is an archive of the discontinued LLVM Phabricator instance.

Add extra acceptable characters to CMICmdArgValFile (MI)
ClosedPublic

Authored by ki.stfu on Feb 24 2015, 7:49 AM.

Details

Summary

Improve CMICmdArgValFile::IsValidChars to accept extra characters that can be in file name:

.'\"`@#$%^&*()_+-={}[]|

Enable MiSyntaxTestCase.test_lldbmi_specialchars test.

All test pass on OS X.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 20598.Feb 24 2015, 7:49 AM
ki.stfu retitled this revision from to Add extra acceptable characters to CMICmdArgValFile (MI).
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, clayborg, emaste, zturner.
ki.stfu added subscribers: abidh, clayborg, emaste and 2 others.
clayborg accepted this revision.Feb 24 2015, 9:59 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2015, 9:59 AM
ki.stfu closed this revision.Feb 24 2015, 10:36 PM