Page MenuHomePhabricator

CMake: Missing GlobalISel TableGen link
AcceptedPublic

Authored by jschueller on Apr 19 2020, 12:14 AM.

Details

Reviewers
dsanders
Summary

Sources from GlobalISel use symbols from TableGen:

  1. libLLVMTableGenGlobalISel.a(GIMatchTree.cpp.obj):GIMatchTree.cpp:(.text+0x8623): undefined reference to `llvm::PrintError(llvm::Twine const&)'

This fixes linking of llvm-tblgen on MinGW

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2020, 12:14 AM
dsanders accepted this revision.Apr 27 2020, 3:22 PM

I don't think it's safe to remove Support since llvm/lib/TableGen/CMakeLists.txt doesn't mention it but adding TableGen to the existing list would LGTM

This revision is now accepted and ready to land.Apr 27 2020, 3:22 PM