Page MenuHomePhabricator

Add -stack-info-frame command (MI)
ClosedPublic

Authored by ki.stfu on Feb 19 2015, 4:25 AM.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 20276.Feb 19 2015, 4:25 AM
ki.stfu retitled this revision from to Add -stack-info-frame command (MI).
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, emaste, clayborg.
ki.stfu added subscribers: abidh, emaste, clayborg, Unknown Object (MLST).
abidh accepted this revision.Feb 19 2015, 6:00 AM
abidh edited edge metadata.

Apart from one comment, look ok.

tools/lldb-mi/MICmdCmdStack.h
80

I think we should not continue this practice of adding the name of the authors.

This revision is now accepted and ready to land.Feb 19 2015, 6:00 AM
emaste added inline comments.Feb 19 2015, 6:21 AM
tools/lldb-mi/MICmdCmdStack.h
80

The Gotchas and Changes header entries are also atypical for LLDB.

Looking through tools/lldb-mi I see exactly one Changes entry that is not 'None`:

MICmnStreamStdin.h:38:// Changes: Factored out OS specific handling of reading stdin  - IOR 16/06/2014.

SVN is very good at tracking changes to these files; there's no need to try to do it manually as well.

I also see only four Gotchas that are not None, two of which are the same. I'd suggest we just avoid these in newly added code.

ki.stfu updated this revision to Diff 20299.Feb 19 2015, 7:14 AM
ki.stfu edited edge metadata.

Remove Gotchas/Authors/Changes sections from header

ki.stfu closed this revision.Feb 19 2015, 7:16 AM
clayborg edited edge metadata.Feb 19 2015, 11:35 AM

Just a quick reminder you might want to use triple quotes instead of desensitizing every other character in the python test case code.

Looks good otherwise.

test/tools/lldb-mi/TestMiStack.py
204

Use triple quotes?

self.expect('''^error,msg="Command 'stack-info-frame'. Invalid process during debug session"''')

212

Triple quotes?

self.expect('''^done,bkpt={number="1"''')
219

triple quotes?

Just a quick reminder you might want to use triple quotes instead of desensitizing every other character in the python test case code.

Looks good otherwise.

Ok. I'll remebmer. Thanks.