This is an archive of the discontinued LLVM Phabricator instance.

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction
ClosedPublic

Authored by dblaikie on Feb 14 2015, 9:39 PM.

Details

Summary

Essentially the same as the GEP change under review in
http://reviews.llvm.org/D7636

A similar migration script can be used to update test cases, though a few more
test case improvements/changes were required this time around: (r229269-r229278)

import fileinput
import sys
import re

pat = re.compile(r"((?:=|:|^)\s*load (?:atomic )?(?:volatile )?(.*?))(| addrspace\(\d+\) *)\*($| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$)")

for line in sys.stdin:

sys.stdout.write(re.sub(pat, r"\1, \2\3*\4", line))

Diff Detail

Repository
rL LLVM

Event Timeline

dblaikie updated this revision to Diff 19977.Feb 14 2015, 9:39 PM
dblaikie retitled this revision from to [opaque pointer type] Add textual IR support for explicit type parameter to load instruction.
dblaikie updated this object.
dblaikie added a subscriber: Unknown Object (MLST).
grosser edited edge metadata.Feb 15 2015, 1:09 AM

I did not test this yet on the Polly code, but don't expect any issues here.

I did not test this yet on the Polly code, but don't expect any issues here.

Thanks - given how many IR changes I'm going to be making, I should/will just setup Polly myself.

At least for a few more patches I'll continue to at least CC a few core owners such as yourself just so people know where things are going, have the migration scripts for any out-of-tree tests, etc.

rafael edited edge metadata.Feb 26 2015, 1:05 PM

Needs tests for the error cases.

lib/AsmParser/LLParser.cpp
5169 ↗(On Diff #19977)

clang-format please.

5187 ↗(On Diff #19977)

This is user input, it can fail.

dblaikie updated this revision to Diff 20807.Feb 26 2015, 4:41 PM
dblaikie edited edge metadata.

rebase, improve error handling, test error handling

rafael accepted this revision.Feb 27 2015, 6:51 AM
rafael edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 27 2015, 6:51 AM
This revision was automatically updated to reflect the committed changes.