This is an archive of the discontinued LLVM Phabricator instance.

[llvm][TextAPI] add simulators to output
ClosedPublic

Authored by cishida on Feb 11 2020, 7:59 AM.

Details

Summary
  • for <= tbd_v3, simulator platforms appear the same as the real

platform and we distinct the difference from the architecture.

fixes: rdar://problem/59161559

Diff Detail

Unit TestsFailed

Event Timeline

cishida created this revision.Feb 11 2020, 7:59 AM
ributzka added inline comments.Feb 11 2020, 8:37 AM
llvm/lib/TextAPI/MachO/TextStubCommon.cpp
68

You could simplify this to use fall-throughs for all the simulator platforms.

cishida added inline comments.Feb 11 2020, 8:39 AM
llvm/lib/TextAPI/MachO/TextStubCommon.cpp
68

wouldn't that trigger a warning with -Wimplicit-fallthrough?

ributzka added inline comments.Feb 11 2020, 8:47 AM
llvm/lib/TextAPI/MachO/TextStubCommon.cpp
68

You can use LLVM_FALLTHROUGH to silence that warning.

cishida updated this revision to Diff 243899.Feb 11 2020, 9:09 AM

Updating to use LLVM_FALLTHROUGH for cases

cishida marked 2 inline comments as done.Feb 11 2020, 9:11 AM
This revision is now accepted and ready to land.Feb 11 2020, 10:08 AM

will resolve the warning: invalid case style for variable '...' [readability-identifier-naming] in a future patch since it'll cause mismatching conventions through the whole file.

This revision was automatically updated to reflect the committed changes.