This is an archive of the discontinued LLVM Phabricator instance.

Style cleanup in comparebyPosition
ClosedPublic

Authored by davide on Feb 3 2015, 4:29 PM.

Reviewers

ruiu

Commits

Summary

Discussed on llvm-commits

davide retitled this revision from to Style cleanup in comparebyPosition.

davide updated this object.

davide edited the test plan for this revision. (Show Details)

davide added a reviewer: ruiu.

davide set the repository for this revision to rL LLVM.

davide added a project: lld.

davide added a subscriber: Unknown Object (MLST).

LGTM

lib/Core/DefinedAtom.cpp
89	Remove this
92	and this blank line.

This revision is now accepted and ready to land.Feb 3 2015, 4:31 PM

Path

Size

lib/

Core/

6 lines

Context not available.

	bool DefinedAtom::compareByPosition(const DefinedAtom *lhs,	bool DefinedAtom::compareByPosition(const DefinedAtom *lhs,
	const DefinedAtom *rhs) {	const DefinedAtom *rhs) {
	const File *lhsFile;
	const File *rhsFile;

	if (lhs == rhs)	if (lhs == rhs)
	return false;	return false;

		ruiuUnsubmitted Not Done Reply Inline Actions Remove this ruiu: Remove this
	lhsFile = &lhs->file();	const File *lhsFile = &lhs->file();
	rhsFile = &rhs->file();	const File *rhsFile = &rhs->file();

		ruiuUnsubmitted Not Done Reply Inline Actions and this blank line. ruiu: and this blank line.
	if (lhsFile->ordinal() != rhsFile->ordinal())	if (lhsFile->ordinal() != rhsFile->ordinal())
	return lhsFile->ordinal() < rhsFile->ordinal();	return lhsFile->ordinal() < rhsFile->ordinal();
Context not available.