This is an archive of the discontinued LLVM Phabricator instance.

[CMake] add_llvm_library: don't use .imp suffix for import libraries on Windows (PR22334)
ClosedPublic

Authored by hans on Feb 3 2015, 1:55 PM.

Details

Summary

This was added in r188351 to fix a naming conflict between the profile_rt-static and profile_rt-shared who both ended up in lib/profile_rt.lib.

The change also affected other libraries (like libclang), and users are reporting that they find it surprising that there's no longer a libclang.lib. Since the profile_rt naming conflict doesn't seem to exist any more, I think we can remove this.

Diff Detail

Repository
rL LLVM

Event Timeline

hans updated this revision to Diff 19264.Feb 3 2015, 1:55 PM
hans retitled this revision from to [CMake] add_llvm_library: don't use .imp suffix for import libraries on Windows (PR22334).
hans updated this object.
hans edited the test plan for this revision. (Show Details)
hans added reviewers: rnk, chapuni.
hans added subscribers: Unknown Object (MLST), hansw.
rnk accepted this revision.Feb 3 2015, 1:59 PM
rnk edited edge metadata.

lgtm

My build of compiler-rt configures without warnings. :)

This revision is now accepted and ready to land.Feb 3 2015, 1:59 PM
This revision was automatically updated to reflect the committed changes.