Page MenuHomePhabricator

Have llgs tests output their traces into session dir
ClosedPublic

Authored by labath on Feb 3 2015, 8:18 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 19229.Feb 3 2015, 8:18 AM
labath retitled this revision from to Have llgs tests output their traces into session dir.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added reviewers: vharron, zturner.
labath added a subscriber: Unknown Object (MLST).
zturner edited edge metadata.Feb 3 2015, 8:28 AM

Can you explain this a bit? I thought we were going to output them to the
lldb-test-traces folder, or whatever location was specified via -s to
dotest. I have a very strong dislike for introducing environment variable
dependencies into the test suite. And this seems to still ignore -s.

labath added a comment.Feb 3 2015, 8:37 AM

This environment variable is already used to communicate info about the session dir.

In dotest.py the variable is set (according to the -s option).
Then lldbtest.py takes it and uses it to output its own logs.

I just copied these two lines from there.

Potentially I could encapsulate it better, put it in a function or something.

Ahh, so just to be clear, both variables are already set, and you're just
reading them? If so that's probably ok.

What do the filenames of the test outputs look like? Is there anything in
the filename to indicate it's a remote test case?

labath added a comment.Feb 3 2015, 8:53 AM

Yes, I am reusing existing variables.

The files look like:
process-TestLldbGdbServer.LldbGdbServerTestCase.test_list_threads_in_stop_reply_supported_llgs.log

No indication of remoteness present.

The other files placed in the folder include the compiler used and architecture (eg. ExpectedFailure-x86_64-_usr_bin_clang-TestConcurrentEvents.ConcurrentEventsTestCase.test_signal_watch_dwarf.log), but still nothing remote.

Ok, lgtm. The files should also have an indication of Success on the front
like the second example you posted. But not urgent and can be done
separately as time permits.

vharron accepted this revision.Feb 3 2015, 10:40 AM
vharron edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 10:40 AM
This revision was automatically updated to reflect the committed changes.