Have llgs tests output their traces into session dir

[labath]

Summary

This reduces the bloat in the source tree and makes the tests more consistent.

[zturner]

Can you explain this a bit? I thought we were going to output them to the
lldb-test-traces folder, or whatever location was specified via -s to
dotest. I have a very strong dislike for introducing environment variable
dependencies into the test suite. And this seems to still ignore -s.

[labath]

This environment variable is already used to communicate info about the session dir.

In dotest.py the variable is set (according to the -s option).
Then lldbtest.py takes it and uses it to output its own logs.

I just copied these two lines from there.

Potentially I could encapsulate it better, put it in a function or something.

[zturner]

Ahh, so just to be clear, both variables are already set, and you're just
reading them? If so that's probably ok.

What do the filenames of the test outputs look like? Is there anything in
the filename to indicate it's a remote test case?

[labath]

Yes, I am reusing existing variables.

The files look like:
process-TestLldbGdbServer.LldbGdbServerTestCase.test_list_threads_in_stop_reply_supported_llgs.log

No indication of remoteness present.

The other files placed in the folder include the compiler used and architecture (eg. ExpectedFailure-x86_64-_usr_bin_clang-TestConcurrentEvents.ConcurrentEventsTestCase.test_signal_watch_dwarf.log), but still nothing remote.

[zturner]

Ok, lgtm. The files should also have an indication of Success on the front
like the second example you posted. But not urgent and can be done
separately as time permits.

lldb/trunk/test/tools/lldb-gdbserver/gdbremote_testcase.py

def get_stub_port_from_named_socket(self, read_timeout_seconds=5):
         self.assertTrue(stub_port > 0)
 
         return stub_port
 
     def init_llgs_test(self, use_named_pipe=True):
         self.debug_monitor_exe = get_lldb_gdbserver_exe()
         if not self.debug_monitor_exe:
             self.skipTest("lldb_gdbserver exe not found")
-        self.debug_monitor_extra_args = " -c 'log enable -T -f process-{}.log lldb break process thread' -c 'log enable -T -f packets-{}.log gdb-remote packets'".format(self.id(), self.id(), self.id())
+        dname = os.path.join(os.environ["LLDB_TEST"],
+                             os.environ["LLDB_SESSION_DIRNAME"])
+        self.debug_monitor_extra_args = " -c 'log enable -T -f {}/process-{}.log lldb break process thread' -c 'log enable -T -f {}/packets-{}.log gdb-remote packets'".format(dname, self.id(), dname, self.id())
         if use_named_pipe:
             (self.named_pipe_path, self.named_pipe, self.named_pipe_fd) = self.create_named_pipe()
 
     def init_debugserver_test(self, use_named_pipe=True):
         self.debug_monitor_exe = get_debugserver_exe()
         if not self.debug_monitor_exe:
             self.skipTest("debugserver exe not found")
         self.debug_monitor_extra_args = " --log-file=/tmp/packets-{}.log --log-flags=0x800000".format(self._testMethodName)