This is an archive of the discontinued LLVM Phabricator instance.

Remove unused tokens from AsmParser.
ClosedPublic

Authored by mewmew on Jan 29 2015, 4:45 AM.

Details

Reviewers
silvas
Summary

The tokens hash and backslash seems to be historical artefacts and are not used anywhere else in the LLVM code base. The LLVM tree (rev 227402) builds just fine with this patch applied and the test cases pass:

Testing Time: 1921.21s

Expected Passes    : 12203
Expected Failures  : 87
Unsupported Tests  : 73

Reference discussion: https://groups.google.com/forum/#!topic/llvm-dev/CcJZnpRXWdE

Diff Detail

Repository
rL LLVM

Event Timeline

mewmew updated this revision to Diff 18952.Jan 29 2015, 4:45 AM
mewmew retitled this revision from to Remove unused tokens from AsmParser..
mewmew updated this object.
mewmew edited the test plan for this revision. (Show Details)
mewmew added a reviewer: silvas.
mewmew set the repository for this revision to rL LLVM.
mewmew added a subscriber: Unknown Object (MLST).
silvas accepted this revision.Jan 29 2015, 6:47 AM
silvas edited edge metadata.

Thanks! Committed r227442

This revision is now accepted and ready to land.Jan 29 2015, 6:47 AM