This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Check register class for AMO memory operands
ClosedPublic

Authored by jrtc27 on Jan 9 2020, 11:47 AM.

Event Timeline

jrtc27 created this revision.Jan 9 2020, 11:47 AM
lenary accepted this revision.Jan 10 2020, 3:11 AM

LGTM. Nice fix!

Please do add a longer summary when committing this patch. Something about the AMO Operands having a custom parser that was accepting more registers than were valid.

This revision is now accepted and ready to land.Jan 10 2020, 3:11 AM
asb accepted this revision.Jan 10 2020, 5:32 AM

Thanks for the fix! As Sam says, explaining the issue in the commit message would be useful.

This revision was automatically updated to reflect the committed changes.