Allow matching "any file" in `VerifyDiagnosticConsumer`.

[arames]

Summary

This allows specifying * for the filename to match any file. For example:

// expected-note@*:* {{Match this note in any file at any line.}}

[arames]

This is for example useful to add a catch-all clause like // expected-note-re@*:* 1+ {{candidate function {{.+}}}}

[jkorous]

clang/test/Frontend/verify-any-file.c

2

I feel that we should test the output with FileCheck to make it more robust.
Seems like other tests for -verify do that. For example here:
https://github.com/llvm/llvm-project/blob/master/clang/test/Frontend/verify-fatal.c

7

Can we add some scenarios for expected diagnostics not produced?

[arames]

clang/test/Frontend/verify-any-file.c

5

While testing, I realized this cannot be handled reliably, so will require the line number to be * when the filename is *.

I was using the current file and specified line for the SourceLocation in this case. But this fails if the specified line number is greater than the number of lines in the current file.

[arames]

Address review comments.

[jkorous]

We should either simplify the implementation to reflect that we don't support e. g. *:42 (seems preferable to me) or have the codepaths that are currently not accessible through -fverify tested by other means.

clang/include/clang/Frontend/VerifyDiagnosticConsumer.h

207

Should we rename it to MatchAnyFileAndLine?

clang/lib/Frontend/VerifyDiagnosticConsumer.cpp

300

Should we make it clear from the interface that MatchAnyFile => MatchAnyLine?

[arames]

In D72100#1855483, @jkorous wrote:

We should either simplify the implementation to reflect that we don't support e. g. *:42 (seems preferable to me) or have the codepaths that are currently not accessible through -fverify tested by other means.

That makes sense. I have updated the naming and added a comment to reflect that. PTAL.
As a note and future reference, the issue was not on the side of the verification; I tested combinations of MatchAnyFile and MatchAnyLine, but the fact that we cannot always create a source location with the appropriate line number when we do not know what file we are dealing with.

clang/lib/Frontend/VerifyDiagnosticConsumer.cpp

300

The naming should now make it clear. Additionally, I have added a comment for the implication in Directive.

[arames]

Rename and clarify.

[arames]

Apply clang-format.

[arames]

Rebase on top of tree.

[jkorous]

LGTM! Thanks for the work!