Do not fail if -fsyntax-only is passed to Fortran compilation. Fixes PR22234.

[tra]

Use PR to prefix bug report number in the test case

Updating D7210: Do not fail if -fsyntax-only is passed to Fortran compilation.

Fixes PR22234.

[echristo]

I'll take a look.

[echristo]

LGTM with the one small change mentioned inline :)

Thanks!

-eric

test/Driver/gfortran.f90

246

Full sentence here including period.

[tra]

Fixed test case comment.

Updating D7210: Do not fail if -fsyntax-only is passed to Fortran compilation.

Fixes PR22234.

[tra]

Removed extraneous comment line.

Updating D7210: Do not fail if -fsyntax-only is passed to Fortran compilation.

Fixes PR22234.

[echristo]

Committed this yesterday, but thanks for this! :)

[tra]

Committed by Eric Christopher <[e-mail]> in r227409.

lib/Driver/Tools.cpp

void gcc::Preprocess::RenderExtraToolArgs(const JobAction &JA,
                                           ArgStringList &CmdArgs) const {
   CmdArgs.push_back("-E");
 }
 
 void gcc::Compile::RenderExtraToolArgs(const JobAction &JA,
                                        ArgStringList &CmdArgs) const {
   const Driver &D = getToolChain().getDriver();
 
+  switch (JA.getType()) {
   // If -flto, etc. are present then make sure not to force assembly output.
-  if (JA.getType() == types::TY_LLVM_IR || JA.getType() == types::TY_LTO_IR ||
-      JA.getType() == types::TY_LLVM_BC || JA.getType() == types::TY_LTO_BC)
+  case types::TY_LLVM_IR:
+  case types::TY_LTO_IR:
+  case types::TY_LLVM_BC:
+  case types::TY_LTO_BC:
     CmdArgs.push_back("-c");
-  else {
-    if (JA.getType() != types::TY_PP_Asm)
-      D.Diag(diag::err_drv_invalid_gcc_output_type)
-        << getTypeName(JA.getType());
-
+    break;
+  case types::TY_PP_Asm:
     CmdArgs.push_back("-S");
+  case types::TY_Nothing:
+    CmdArgs.push_back("-fsyntax-only");
+    break;
+  default:
+    D.Diag(diag::err_drv_invalid_gcc_output_type) << getTypeName(JA.getType());
   }
 }
 
 void gcc::Link::RenderExtraToolArgs(const JobAction &JA,
                                     ArgStringList &CmdArgs) const {
   // The types are (hopefully) good enough.
 }
 

test/Driver/gfortran.f90

 ! CHECK: "-pedantic"
 ! CHECK: "-pedantic-errors"
 ! CHECK: "-static-libgfortran"
 ! CHECK: "-std=f90"
 ! CHECK: "-undef"
 !
 ! Clang understands this one and orders it weirdly.
 ! CHECK: "-fsyntax-only"
+
+! PR22234: Verifies that -fsyntax-only no longer fails with fortran files.
+!
+! RUN: %clang -no-canonical-prefixes -target i386-linux -fsyntax-only -### %s -o %t 2>&1 | \
+! grep for error message and command-line
+! RUN: grep -e error: -e -fsyntax-only | FileCheck %s --check-prefix=CHECK-PR22234
+!
+! CHECK-PR22234-NOT: clang: error: invalid output type
+! CHECK-PR22234: "-fsyntax-only"