Clear should reset error to invalid instead of generic

[sivachandra]

source/Core/Error.cpp

149 ↗

(On Diff #18572)

Drive by comment:
While I do not know if this OK or not, you should explain why this change is required in your commit message.

[zturner]

It would help to see some context (eg generating the diff with -U999999. I
was trying to find the constructor, because I figure it should reset it to
whatever the constructor initializes it to, but I can't see that here.

Anyway, lgtm as long as this is what the constructor does.

[chaoren]

It doesn't make much of a difference really, but the default type of an
error is invalid. It seems weird that clear doesn't produce the same thing
as the default constructor.

[chaoren]

Here's more context. The default constructor uses eErrorTypeInvalid, so Clear() should also reset to eErrorTypeInvalid.

[zturner]

Thanks. lgtm

[clayborg]

lgtm

[chaoren]

Could someone commit this for me please? I don't think I have commit access.

[zturner]

I'll do it.

lldb/trunk/source/Core/Error.cpp

 
 //----------------------------------------------------------------------
 // Clear the error and any cached error string that it might contain.
 //----------------------------------------------------------------------
 void
 Error::Clear ()
 {
     m_code = 0;
-    m_type = eErrorTypeGeneric;
+    m_type = eErrorTypeInvalid;
     m_string.clear();
 }
 
 //----------------------------------------------------------------------
 // Access the error value.
 //----------------------------------------------------------------------
 Error::ValueType
 Error::GetError () const