This is an archive of the discontinued LLVM Phabricator instance.

I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/warnings. I Also ran the test suite it using `lit` and passed all the unit tests.
Needs RevisionPublic

Authored by Afadyfarag on Nov 27 2019, 12:48 AM.

Details

Summary
  1. Changes:

    libcxx/include/numeric

Event Timeline

Afadyfarag created this revision.Nov 27 2019, 12:48 AM
mclow.lists requested changes to this revision.Nov 27 2019, 11:55 AM

This is a mess.
The changes in libcxx/CMakeLists.txt are unrelated to P0616.
The changes in algorithm are also unrelated to P0616.
The changes in forward_list are also unrelated to P0616, and are based on an outdated version of that file.
You proposed the changes in numeric before (in D69286) and then never came back to them.
And you have no tests.

Please don't keep proposing the same things over and over.

This revision now requires changes to proceed.Nov 27 2019, 11:55 AM
aprantl added a subscriber: aprantl.