This is an archive of the discontinued LLVM Phabricator instance.

[Format] Add format check for coroutine keywords with negative numbers
ClosedPublic

Authored by jonathoma on Oct 18 2019, 9:30 AM.

Details

Summary

As a followup to D69144, this diff fixes the coroutine keyword spacing
for co_yield / co_returning negative numbers.

Event Timeline

jonathoma created this revision.Oct 18 2019, 9:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2019, 9:30 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
jonathoma planned changes to this revision.Oct 18 2019, 9:33 AM

Rebase onto master

Rebase properly

Harbormaster completed remote builds in B39800: Diff 225672.
modocache accepted this revision.Nov 21 2019, 7:42 PM

LGTM! Let me know if you'd like me to commit this change.

This revision is now accepted and ready to land.Nov 21 2019, 7:42 PM

@modocache Feel free to commit from my end! Thanks again :)

modocache added inline comments.Nov 30 2019, 12:48 PM
clang/lib/Format/TokenAnnotator.cpp
1760

I didn't notice this during review, but tok_kw_co_yield is a typo. I'm replacing this with tok::kw_co_yield in the commit I'm making for this patch, as that spelling allows the build and tests to pass.

This revision was automatically updated to reflect the committed changes.