This is an archive of the discontinued LLVM Phabricator instance.

Differential D6743

No need to call SetErrorToErrno when pipe2 succeeds.
ClosedPublic

Authored by ovyalov on Dec 19 2014, 3:14 PM.

Details

Reviewers
zturner
Summary

In http://reviews.llvm.org/D6686 I mistakenly advised to call SetErrorToErrno when pipe2 succeeds - this causes TestCommandSource to fail on Linux.
Removing SetErrorToErrno call from successful execution branch.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 17523.Dec 19 2014, 3:14 PM
ovyalov retitled this revision from to No need to call SetErrorToErrno when pipe2 succeeds..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added a reviewer: zturner.
ovyalov added a subscriber: Unknown Object (MLST).
zturner accepted this revision.Dec 19 2014, 3:18 PM
zturner edited edge metadata.

Ahh, good catch. I should have noticed that too. Thanks

This revision is now accepted and ready to land.Dec 19 2014, 3:18 PM
Eugene.Zelenko closed this revision.Sep 21 2016, 6:07 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r224652.

Revision Contents

PathSize
source/
Host/
posix/
3 lines

Diff 17523

source/Host/posix/PipePosix.cpp

Context not available.
#if PIPE2_SUPPORTED #if PIPE2_SUPPORTED
if (::pipe2(m_fds, (child_processes_inherit) ? 0 : O_CLOEXEC) == 0) if (::pipe2(m_fds, (child_processes_inherit) ? 0 : O_CLOEXEC) == 0)
{
error.SetErrorToErrno();
return error; return error;
}
#else #else
if (::pipe(m_fds) == 0) if (::pipe(m_fds) == 0)
{ {
Context not available.