Page MenuHomePhabricator

[TargetLowering][PS4] Add sincos(f) lib functions when target is PS4
ClosedPublic

Authored by rob.lougher on Aug 30 2019, 10:03 AM.

Details

Summary

PS4 supports sincosf and sincos. This patch enables the sin(f)+cos(f) -> sincos(f) optimization.

Diff Detail

Repository
rL LLVM

Event Timeline

rob.lougher created this revision.Aug 30 2019, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2019, 10:03 AM

I'm happy if Simon's happy.

Thanks @rob.lougher! Just one minor - please can you add PS4_SINCOS checks to the x86_fp80 tests to ensure those calls stays separate?

Updated test3 and test3_errno to check that sinl+cosl does not get transformed into sincosl.

RKSimon accepted this revision.Sep 2 2019, 8:42 AM

LGTM - thanks

This revision is now accepted and ready to land.Sep 2 2019, 8:42 AM
This revision was automatically updated to reflect the committed changes.