This is an archive of the discontinued LLVM Phabricator instance.

[gold] Fix X86/strip_names.ll after r367755
AbandonedPublic

Authored by nathanchance on Aug 4 2019, 12:52 PM.

Details

Summary

Running ninja check-llvm fails like so:

[401/402] Running the LLVM regression tests
FAIL: LLVM :: tools/gold/X86/strip_names.ll (31009 of 32927)
...
Exit Code: 1

Command Output (stderr):
--
/home/nathan/cbl/tc-build/llvm-project/llvm/test/tools/gold/X86/strip_names.ll:23:11:
error: NONAME: expected string not found in input
; NONAME: @foo(i32)
          ^
<stdin>:6:18: note: scanning from here
@GlobalValueName = global i32 0
                 ^
<stdin>:8:12: note: possible intended match here
define i32 @foo(i32 %0) {
           ^

--

This appears to be missed by r367755 (git commit a009a60a917bc30940422bcef73f8270566d78db),
as running the script on it does not produce this diff and I do not know
enough about Python to fix it.

After this, the regression tests pass as expected.

Event Timeline

nathanchance created this revision.Aug 4 2019, 12:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2019, 12:52 PM
nathanchance edited the summary of this revision. (Show Details)Aug 4 2019, 12:53 PM

I believe this same fix was applied in r368281, and that this is now obsolete. (Sorry for the delayed review, I was out last week)

nathanchance abandoned this revision.Aug 12 2019, 9:47 AM

Yes, it does look like that is the case, I will abandon this. Thanks for the reply!