This is an archive of the discontinued LLVM Phabricator instance.

[llgo] Optimize comparisons to empty string.
ClosedPublic

Authored by pcc on Dec 8 2014, 12:10 PM.

Details

Summary

Geo-mean performance improvement of 0.2% (-0.3% - 0.9% @ 95% CI).

Diff Detail

Event Timeline

pcc updated this revision to Diff 17048.Dec 8 2014, 12:10 PM
pcc retitled this revision from to [llgo] Optimize comparisons to empty string..
pcc updated this object.
pcc edited the test plan for this revision. (Show Details)
pcc added a reviewer: axw.
pcc added a subscriber: Unknown Object (MLST).
axw accepted this revision.Dec 8 2014, 4:51 PM
axw edited edge metadata.

LGTM.

irgen/strings.go
29–31

result := fr.builder.CreateIsNull(len, "")
?

This revision is now accepted and ready to land.Dec 8 2014, 4:51 PM
pcc closed this revision.Dec 8 2014, 5:02 PM
pcc updated this revision to Diff 17064.

Closed by commit rL223728 (authored by @pcc).

irgen/strings.go
29–31

Done.