Page MenuHomePhabricator

[WebAssembly] Fixed relocation errors having no location.
ClosedPublic

Authored by aardappel on Aug 1 2019, 12:54 PM.

Details

Summary

Fixes: https://bugs.llvm.org/show_bug.cgi?id=42441

Used to print:

<unknown>:0: error: Cannot represent a difference across sections

(the location was null).

Now prints:

err.s:20:3: error: Cannot represent a difference across sections

i32.const foo-bar
^

Note: I looked at adding a test for this, but I don't think it is
worth it. We're not testing error formatting in the Wasm backend :)

Diff Detail

Repository
rL LLVM

Event Timeline

aardappel created this revision.Aug 1 2019, 12:54 PM
This revision is now accepted and ready to land.Aug 1 2019, 2:19 PM
This revision was automatically updated to reflect the committed changes.