Fix PR21684 - Ellipsis at end of generic lambda parameter-declaration-clause should be parsed as a parameter pack

[faisalv]

Summary

See reddit post for some additional context: http://www.reddit.com/r/cpp/comments/2nkcvi/generic_lambda_inconsistency/

An ellipsis following an auto should always be parsed as a parameter pack, not as a c-variadic.

[](auto ...) { }();  // OK.

[rsmith]

lib/Parse/ParseDecl.cpp

4882–4888

Please keep this existing code structure and just add the check for 'auto' to the end, or factor out a meaningful part of this into a separate function. Adding a page full of semi-unrelated code into the middle of a function like this makes it harder to read, and the code communicates its intent well enough without the comments.

[faisalv]

I had a sneaking suspicion the refactoring wouldn't fly - and while I find such singular uses of lambdas adding clarity when used judiciously - I can certainly appreciate your concerns here. Mostly, thanks for articulating your rationale! =)

Committed as r223357 (http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20141201/119491.html) per your preference.

Thanks!

[faisalv]

Committed as r223357 (http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20141201/119491.html) per your preference.

Thanks!

lib/Parse/ParseDecl.cpp

     }
 
     // C++0x [dcl.fct]p14:
-    //   There is a syntactic ambiguity when an ellipsis occurs at the end
-    //   of a parameter-declaration-clause without a preceding comma. In
-    //   this case, the ellipsis is parsed as part of the
-    //   abstract-declarator if the type of the parameter names a template
-    //   parameter pack that has not been expanded; otherwise, it is parsed
-    //   as part of the parameter-declaration-clause.
-    if (Tok.is(tok::ellipsis) && D.getCXXScopeSpec().isEmpty() &&
-        !((D.getContext() == Declarator::PrototypeContext ||
-           D.getContext() == Declarator::LambdaExprParameterContext ||
-           D.getContext() == Declarator::BlockLiteralContext) &&
-          NextToken().is(tok::r_paren) &&
-          !D.hasGroupingParens() &&
-          !Actions.containsUnexpandedParameterPacks(D))) {
+    //   There is a syntactic ambiguity when an ellipsis occurs at the end of a
+    //   parameter-declaration-clause without a preceding comma. In this case,
+    //   the ellipsis is parsed as part of the abstract-declarator if the type
+    //   of the parameter either names a template parameter pack that has not
+    //   been expanded or contains auto; otherwise, it is parsed as part of the
+    //   parameter-declaration-clause.
+    auto IsEllipsisThatShouldBeParsedAsAbstractDeclarator =
+        [this](const Token &CurTok, Declarator &D) {
+      if (!CurTok.is(tok::ellipsis))
+        return false;
+      // Any scope specifier prevents integrating the ellipsis into the
+      // Declarator.
+      if (!D.getCXXScopeSpec().isEmpty())
+        return false;
+      
+      const Declarator::TheContext DCtx = D.getContext();
+      const bool IsParameterDeclarationContext =
+          DCtx == Declarator::PrototypeContext ||
+          DCtx == Declarator::LambdaExprParameterContext ||
+          DCtx == Declarator::BlockLiteralContext;
+
+      // If not in a parameter declaration context; it's a parameter pack.
+      if (!IsParameterDeclarationContext)
+        return true;
+      // Or if the next token is not a right paren; it's a parameter pack.
+      if (!this->NextToken().is(tok::r_paren))
+        return true;
+      // Or if the decl-specifier is 'auto'; it's a parameter pack.
+      if (D.getDeclSpec().getTypeSpecType() == TST_auto)
+        return true;
+      // Or if there are grouping parens; it's a parameter pack.
+      if (D.hasGroupingParens())
+        return true;
+      // Or if the declarator contains an unexpanded parameter pack
+      return this->Actions.containsUnexpandedParameterPacks(D);
+    };
+    if (IsEllipsisThatShouldBeParsedAsAbstractDeclarator(Tok, D)) {
       SourceLocation EllipsisLoc = ConsumeToken();
       if (isPtrOperatorToken(Tok.getKind(), getLangOpts(), D.getContext())) {
         // The ellipsis was put in the wrong place. Recover, and explain to

test/SemaCXX/cxx1y-generic-lambdas.cpp

 
 
 } //end ns inclass_lambdas_within_nested_classes
+
+namespace pr21684_disambiguate_auto_followed_by_ellipsis_no_id {
+int a = [](auto ...) { return 0; }();
+}
 No newline at end of file