Page MenuHomePhabricator

faisalv (Faisal Vali)
Faisal Vali

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2012, 12:47 PM (420 w, 2 d)

Recent Activity

Wed, Nov 25

faisalv added a comment to D91651: [clang] Add a warning (à la gcc) for too small enum bitfields.

Do you have any numbers on false positives / true positives uncovered by this tweak?

Wed, Nov 25, 9:34 PM · Restricted Project

Mon, Nov 23

faisalv requested review of D91651: [clang] Add a warning (à la gcc) for too small enum bitfields.

*ping*

Mon, Nov 23, 7:35 PM · Restricted Project

Sat, Nov 21

faisalv closed D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.

committed here: https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a

Sat, Nov 21, 7:52 AM · Restricted Project
faisalv committed rG9930d4dff31a: [NFC, Refactor] Modernize enum FunctionDefinitionKind (DeclSpech.h) into a… (authored by faisalv).
[NFC, Refactor] Modernize enum FunctionDefinitionKind (DeclSpech.h) into a…
Sat, Nov 21, 7:51 AM

Fri, Nov 20

faisalv added a comment to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.

*ping*

Fri, Nov 20, 7:09 AM · Restricted Project

Thu, Nov 19

faisalv requested review of D91821: Fix PR42049 - Crash when parsing bad decltype use within template argument list after name assumed to be a function template.
Thu, Nov 19, 1:42 PM · Restricted Project

Tue, Nov 17

faisalv planned changes to D91651: [clang] Add a warning (à la gcc) for too small enum bitfields.
Tue, Nov 17, 9:34 PM · Restricted Project
faisalv updated the diff for D91651: [clang] Add a warning (à la gcc) for too small enum bitfields.

Based on Richards Feedback, this update includes the following changes:

  • avoids calling the fragile getZextValue() for comparing against bit-field width, and uses APSInt's comparison operator overload
  • suppresses/avoids the warning for unnamed bit-fields
  • simplifies the test case and avoids preprocessor cleverness (and thus an extra pass).
Tue, Nov 17, 9:27 PM · Restricted Project
faisalv requested review of D91651: [clang] Add a warning (à la gcc) for too small enum bitfields.
Tue, Nov 17, 11:22 AM · Restricted Project

Sun, Nov 15

faisalv closed D91409: [NFC, Refactor] Convert TypeSpecifierWidth from Specifiers.h to a scoped enum.

Committed here: https://github.com/llvm/llvm-project/commit/e6aa06545b123292be283af7c414daead23cf9ab .

Sun, Nov 15, 9:19 AM
faisalv committed rGe6aa06545b12: [NFC, Refactor] Modernize the TypeSpecifierWidth enum (Specifiers.h) to a… (authored by faisalv).
[NFC, Refactor] Modernize the TypeSpecifierWidth enum (Specifiers.h) to a…
Sun, Nov 15, 9:17 AM

Sat, Nov 14

faisalv updated subscribers of D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.

Thanks Thorsten - if no one else does it - i'll try and commit this for you
later today :)

Sat, Nov 14, 9:32 AM · Restricted Project
faisalv updated the diff for D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.

This diff makes the following changes to the previous patch (based on feedback from Richard, Aaron and Wyatt):

  • avoid introducing an initialism (FDK) into the clang namespace and unabbreviated each corresponding use to 'FunctionDefinitionKind'. Let me know if it seems too verbose - if so, perhaps a compromise along Wyatt's suggestion might behoove our source.
  • changed the destination type from 'unsigned' to 'unsigned char' in our static_casts.
    • is that preferred, or should i have left it as 'unsigned'?
    • is there any real benefit here to specifying an underlying type of 'unsigned char' for our enum (that is never used as an opaque enum).
Sat, Nov 14, 8:55 AM · Restricted Project

Thu, Nov 12

faisalv updated the diff for D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.

This revision includes the following changes to the initial patch:

  • revert the bit-field to unsigned from enum (so as to avoid that nettlesome gcc warning)
  • specified a fixed underlying type of 'unsigned char' for the enum FunctionDefinitionKind
  • added static_casts when initiatilizing or assigning to the bit-field (which as Aaron astutely noticed was confined to the ctor and setter)
Thu, Nov 12, 8:59 PM · Restricted Project

Wed, Nov 11

faisalv added inline comments to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.
Wed, Nov 11, 5:26 AM · Restricted Project

Tue, Nov 10

faisalv closed D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy.

Committed: https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9

Tue, Nov 10, 9:44 PM · Restricted Project
faisalv committed rGe4d27932a59f: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to… (authored by faisalv).
[NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to…
Tue, Nov 10, 9:40 PM

Mon, Nov 9

faisalv added a comment to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.

Generally agree with this direction; Are there plans for migrating https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Basic/Specifiers.h in a similar fashion, for consistency?

Mon, Nov 9, 12:31 PM · Restricted Project

Sun, Nov 8

faisalv requested review of D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.
Sun, Nov 8, 9:38 AM · Restricted Project

Sat, Nov 7

faisalv added reviewers for D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy: wchilders, BRevzin.
Sat, Nov 7, 6:04 PM · Restricted Project
faisalv retitled D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy from [NFC, Refactor] Rename the (scoped) enum DeclaratorContext enumerator's to avoid redundancy to [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy.
Sat, Nov 7, 12:51 PM · Restricted Project
faisalv requested review of D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy.
Sat, Nov 7, 12:33 PM · Restricted Project

May 16 2020

faisalv added a reverting change for rG0ee46e857d81: [nfc] test commit: rGaccd9af838b0: Revert "[nfc] test commit".
May 16 2020, 1:45 PM
faisalv committed rGaccd9af838b0: Revert "[nfc] test commit" (authored by faisalv).
Revert "[nfc] test commit"
May 16 2020, 1:45 PM
faisalv committed rG0ee46e857d81: [nfc] test commit (authored by faisalv).
[nfc] test commit
May 16 2020, 1:13 PM

Apr 25 2018

faisalv committed rC330889: Fix a merge conflict that was inadvertently introduced in r330888 .
Fix a merge conflict that was inadvertently introduced in r330888
Apr 25 2018, 6:08 PM
faisalv committed rL330889: Fix a merge conflict that was inadvertently introduced in r330888 .
Fix a merge conflict that was inadvertently introduced in r330888
Apr 25 2018, 6:08 PM
faisalv committed rL330888: Revert rC330794 and some dependent tiny bug fixes .
Revert rC330794 and some dependent tiny bug fixes
Apr 25 2018, 5:46 PM
faisalv committed rC330888: Revert rC330794 and some dependent tiny bug fixes .
Revert rC330794 and some dependent tiny bug fixes
Apr 25 2018, 5:46 PM
faisalv added a reverting change for rC330794: [c++2a] [concepts] Add rudimentary parsing support for template concept…: rC330888: Revert rC330794 and some dependent tiny bug fixes .
Apr 25 2018, 5:46 PM

Apr 24 2018

faisalv committed rC330798: [NFC] Make dependent parameter non-deducible, so that we are forced to use the….
[NFC] Make dependent parameter non-deducible, so that we are forced to use the…
Apr 24 2018, 8:57 PM
faisalv committed rL330798: [NFC] Make dependent parameter non-deducible, so that we are forced to use the….
[NFC] Make dependent parameter non-deducible, so that we are forced to use the…
Apr 24 2018, 8:57 PM
faisalv committed rC330796: Fix rC330794 - a parameter that should have been dependent was inadvertently….
Fix rC330794 - a parameter that should have been dependent was inadvertently…
Apr 24 2018, 8:32 PM
faisalv committed rL330796: Fix rC330794 - a parameter that should have been dependent was inadvertently….
Fix rC330794 - a parameter that should have been dependent was inadvertently…
Apr 24 2018, 8:31 PM
faisalv committed rC330794: [c++2a] [concepts] Add rudimentary parsing support for template concept….
[c++2a] [concepts] Add rudimentary parsing support for template concept…
Apr 24 2018, 7:46 PM
faisalv committed rL330794: [c++2a] [concepts] Add rudimentary parsing support for template concept….
[c++2a] [concepts] Add rudimentary parsing support for template concept…
Apr 24 2018, 7:46 PM

Apr 4 2018

faisalv added a comment to D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class..

LGTM - can you commit?
Thank you!

Apr 4 2018, 2:03 PM
faisalv added a comment to D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class..

Thanks Erik!

Apr 4 2018, 11:54 AM

Apr 3 2018

faisalv added a comment to D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class..

Thanks for working on this fairly embarrassing bug (let's fix this before the week is over :)

Apr 3 2018, 8:56 PM

Mar 14 2018

faisalv added a comment to D40381: Parse concept definition.

I discussed this briefly w Hubert - and i'm planning on modifying this patch slightly so that it flows through ParseDeclSpecifier and handles attributes and other invalid decl-specifiers such as static etc. more gracefully on a concept decl. I have this partially implemented - my hope is to get this done v soonish so feel free to ping me if you don't hear anything about this in a week or so ...

Mar 14 2018, 6:27 PM · Restricted Project
faisalv added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Mar 14 2018, 10:32 AM · Restricted Project
faisalv added a reviewer for D41217: [Concepts] Concept Specialization Expressions: faisalv.
Mar 14 2018, 9:31 AM · Restricted Project
faisalv added a reviewer for D41284: [Concepts] Associated constraints infrastructure.: faisalv.
Mar 14 2018, 9:30 AM · Restricted Project

Jan 1 2018

faisalv committed rL321628: Again reverting an attempt to convert the DeclSpec enums into scoped enums..
Again reverting an attempt to convert the DeclSpec enums into scoped enums.
Jan 1 2018, 10:24 AM
faisalv committed rC321628: Again reverting an attempt to convert the DeclSpec enums into scoped enums..
Again reverting an attempt to convert the DeclSpec enums into scoped enums.
Jan 1 2018, 10:24 AM
faisalv committed rC321625: Use 'unsigned int' instead of enum bit-fields to silence some warnings from….
Use 'unsigned int' instead of enum bit-fields to silence some warnings from…
Jan 1 2018, 8:38 AM
faisalv committed rL321625: Use 'unsigned int' instead of enum bit-fields to silence some warnings from….
Use 'unsigned int' instead of enum bit-fields to silence some warnings from…
Jan 1 2018, 8:38 AM
faisalv committed rL321622: [NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType….
[NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType…
Jan 1 2018, 7:43 AM
faisalv committed rC321622: [NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType….
[NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType…
Jan 1 2018, 7:43 AM

Dec 31 2017

faisalv committed rC321616: Revert r321614 and r321615.
Revert r321614 and r321615
Dec 31 2017, 6:50 PM
faisalv committed rL321616: Revert r321614 and r321615.
Revert r321614 and r321615
Dec 31 2017, 6:50 PM
faisalv committed rC321615: Add scope specifiers to updated scoped-enums (that I somehow missed in r321614).
Add scope specifiers to updated scoped-enums (that I somehow missed in r321614)
Dec 31 2017, 6:37 PM
faisalv committed rL321615: Add scope specifiers to updated scoped-enums (that I somehow missed in r321614).
Add scope specifiers to updated scoped-enums (that I somehow missed in r321614)
Dec 31 2017, 6:36 PM
faisalv committed rC321614: [NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType….
[NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType…
Dec 31 2017, 6:21 PM
faisalv committed rL321614: [NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType….
[NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType…
Dec 31 2017, 6:21 PM

Dec 30 2017

faisalv committed rL321590: [NFC] Modernize enum DeclSpecContext into a scoped enum..
[NFC] Modernize enum DeclSpecContext into a scoped enum.
Dec 30 2017, 4:08 PM
faisalv committed rC321590: [NFC] Modernize enum DeclSpecContext into a scoped enum..
[NFC] Modernize enum DeclSpecContext into a scoped enum.
Dec 30 2017, 4:08 PM

Dec 29 2017

faisalv committed rC321574: [NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum….
[NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum…
Dec 29 2017, 8:16 PM
faisalv committed rL321574: [NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum….
[NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum…
Dec 29 2017, 8:16 PM

Dec 28 2017

faisalv committed rL321546: [NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum..
[NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum.
Dec 28 2017, 9:42 PM
faisalv committed rC321546: [NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum..
[NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum.
Dec 28 2017, 9:42 PM

Dec 27 2017

faisalv added a comment to D41179: [Sema] Diagnose template specializations with C linkage.
Classes do not have language linkage according to 10.5p1, just as templates, so this code is valid.

It looks like defining templates inside extern "C" blocks is OK.

Currently both Clang and GCC diagnose class templates declared inside an 'extern "C"' block. I'm not sure how to proceed about this.

Dec 27 2017, 7:25 AM

Dec 25 2017

faisalv committed rC321449: Add a fixit for attributes incorrectly placed prior to 'struct/class/enum'….
Add a fixit for attributes incorrectly placed prior to 'struct/class/enum'…
Dec 25 2017, 2:25 PM
faisalv committed rL321449: Add a fixit for attributes incorrectly placed prior to 'struct/class/enum'….
Add a fixit for attributes incorrectly placed prior to 'struct/class/enum'…
Dec 25 2017, 2:24 PM

Dec 24 2017

faisalv added inline comments to D40381: Parse concept definition.
Dec 24 2017, 11:23 AM · Restricted Project
faisalv added a comment to D40381: Parse concept definition.

I think this looks good enough to commit - do you have commit privileges - or do you need one of us to commit it for you?
thank you!

Dec 24 2017, 10:00 AM · Restricted Project

Dec 23 2017

faisalv committed rL321410: [NFC] Remove a cast rendered unnecessary by r321409.
[NFC] Remove a cast rendered unnecessary by r321409
Dec 23 2017, 11:28 AM
faisalv committed rC321410: [NFC] Remove a cast rendered unnecessary by r321409.
[NFC] Remove a cast rendered unnecessary by r321409
Dec 23 2017, 11:28 AM
faisalv committed rC321409: [NFC] Update the template-parameter parsers and analyzers to return NamedDecl….
[NFC] Update the template-parameter parsers and analyzers to return NamedDecl…
Dec 23 2017, 10:58 AM
faisalv committed rL321409: [NFC] Update the template-parameter parsers and analyzers to return NamedDecl….
[NFC] Update the template-parameter parsers and analyzers to return NamedDecl…
Dec 23 2017, 10:57 AM
faisalv added inline comments to D40381: Parse concept definition.
Dec 23 2017, 9:10 AM · Restricted Project

Dec 21 2017

faisalv closed D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!).

Added via https://reviews.llvm.org/rC321339

Dec 21 2017, 7:54 PM · Restricted Project, Restricted Project
faisalv committed rC321339: Diagnose the various invalid decl-specifiers on nontype template parameters..
Diagnose the various invalid decl-specifiers on nontype template parameters.
Dec 21 2017, 7:51 PM
faisalv committed rL321339: Diagnose the various invalid decl-specifiers on nontype template parameters..
Diagnose the various invalid decl-specifiers on nontype template parameters.
Dec 21 2017, 7:51 PM

Dec 20 2017

faisalv updated the diff for D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!).

Miyuki - please take a look at the patch and let me know if you agree with the changes - or have any concerns...

Dec 20 2017, 8:55 PM · Restricted Project, Restricted Project
faisalv commandeered D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!).
Dec 20 2017, 8:46 PM · Restricted Project, Restricted Project
faisalv added a comment to D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!).

Sounds good - if I don't get this done over the next seven days - would you mind just pinging me!

Dec 20 2017, 10:12 AM · Restricted Project, Restricted Project

Dec 19 2017

faisalv requested changes to D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!).

Hmm - I think i might make some tweaks to this patch (to be largely symmetric with the similar handling of invalid decl-specifiers on function parameters in Sema::Actions.ActOnParamDeclarator)...

Dec 19 2017, 8:33 PM · Restricted Project, Restricted Project

Dec 17 2017

faisalv added inline comments to D41179: [Sema] Diagnose template specializations with C linkage.
Dec 17 2017, 7:58 PM
faisalv requested changes to D40381: Parse concept definition.
Dec 17 2017, 3:17 PM · Restricted Project
faisalv accepted D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!).

Otherwise, I think this looks good enough to commit.

Dec 17 2017, 1:11 PM · Restricted Project, Restricted Project
faisalv requested changes to D40381: Parse concept definition.
Dec 17 2017, 8:57 AM · Restricted Project
faisalv added a comment to D40381: Parse concept definition.

Thanks for working on this! :)

Dec 17 2017, 8:55 AM · Restricted Project

Dec 16 2017

faisalv added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Dec 16 2017, 6:48 PM · Restricted Project

Dec 1 2017

faisalv added inline comments to D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!).
Dec 1 2017, 3:41 AM · Restricted Project, Restricted Project

Nov 11 2017

faisalv abandoned D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?.

Just added an additional bit-field to FunctionDecl in https://reviews.llvm.org/rL317984

Nov 11 2017, 10:11 AM · Restricted Project
faisalv committed rL317984: Adjust r316292 - remove the anonymous union for sharing a bitfield in….
Adjust r316292 - remove the anonymous union for sharing a bitfield in…
Nov 11 2017, 10:04 AM

Oct 25 2017

faisalv updated the diff for D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?.

Incorporated Aaron's feedback (although not sure if I caugh tall the white space issues).

Oct 25 2017, 6:27 PM · Restricted Project

Oct 22 2017

faisalv committed rL316304: [c++2a] Update cxx_status w __VA_OPT__ marked as completed in SVN..
[c++2a] Update cxx_status w __VA_OPT__ marked as completed in SVN.
Oct 22 2017, 3:30 PM
faisalv added a comment to D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?.

Isn't it already an UB if someone set WillHaveBody and but later IsCopyDeductionCandidate being read, vice versa?

Oct 22 2017, 1:38 PM · Restricted Project
faisalv created D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?.
Oct 22 2017, 12:47 PM · Restricted Project
faisalv committed rL316292: [C++17] Fix PR34970 - tweak overload resolution for class template deduction….
[C++17] Fix PR34970 - tweak overload resolution for class template deduction…
Oct 22 2017, 7:47 AM

Oct 15 2017

faisalv abandoned D35782: [C++2a][Preprocessor] Implement p0306 __VA_OPT__ (Comma omission and comma deletion).

committed as r315840.
https://reviews.llvm.org/rL315840

Oct 15 2017, 7:04 PM · Restricted Project

Oct 14 2017

faisalv committed rL315842: [c++2a] Fix failing regression test related to not adding the extension warning….
[c++2a] Fix failing regression test related to not adding the extension warning…
Oct 14 2017, 7:13 PM
faisalv committed rL315840: [c++2a] Implement P0306 __VA_OPT__ (Comma omission and comma deletion).
[c++2a] Implement P0306 __VA_OPT__ (Comma omission and comma deletion)
Oct 14 2017, 6:26 PM

Oct 2 2017

faisalv committed rL314753: Add parens around the boolean condition of one of the added asserts in r314747 ..
Add parens around the boolean condition of one of the added asserts in r314747 .
Oct 2 2017, 6:35 PM
faisalv committed rL314748: Remove an assertion I added from the refactoring of pasteTokens (https….
Remove an assertion I added from the refactoring of pasteTokens (https…
Oct 2 2017, 6:22 PM
faisalv committed rL314747: [NFC] Refactor PasteTokens so that it can be passed the Token Stream and Index….
[NFC] Refactor PasteTokens so that it can be passed the Token Stream and Index…
Oct 2 2017, 5:54 PM

Sep 30 2017

faisalv committed rL314600: [NFC] Add assertion that we assume a valid macro argument index..
[NFC] Add assertion that we assume a valid macro argument index.
Sep 30 2017, 12:36 PM
faisalv committed rL314595: [NFC] Sync function call with changes to interface made in r314593..
[NFC] Sync function call with changes to interface made in r314593.
Sep 30 2017, 7:37 AM