- User Since
- Nov 12 2012, 12:47 PM (420 w, 2 d)
Wed, Nov 25
Mon, Nov 23
Sat, Nov 21
Fri, Nov 20
Thu, Nov 19
Tue, Nov 17
Based on Richards Feedback, this update includes the following changes:
- avoids calling the fragile getZextValue() for comparing against bit-field width, and uses APSInt's comparison operator overload
- suppresses/avoids the warning for unnamed bit-fields
- simplifies the test case and avoids preprocessor cleverness (and thus an extra pass).
Sun, Nov 15
Sat, Nov 14
Thanks Thorsten - if no one else does it - i'll try and commit this for you
later today :)
This diff makes the following changes to the previous patch (based on feedback from Richard, Aaron and Wyatt):
- avoid introducing an initialism (FDK) into the clang namespace and unabbreviated each corresponding use to 'FunctionDefinitionKind'. Let me know if it seems too verbose - if so, perhaps a compromise along Wyatt's suggestion might behoove our source.
- changed the destination type from 'unsigned' to 'unsigned char' in our static_casts.
- is that preferred, or should i have left it as 'unsigned'?
- is there any real benefit here to specifying an underlying type of 'unsigned char' for our enum (that is never used as an opaque enum).
Thu, Nov 12
This revision includes the following changes to the initial patch:
- revert the bit-field to unsigned from enum (so as to avoid that nettlesome gcc warning)
- specified a fixed underlying type of 'unsigned char' for the enum FunctionDefinitionKind
- added static_casts when initiatilizing or assigning to the bit-field (which as Aaron astutely noticed was confined to the ctor and setter)
Wed, Nov 11
Tue, Nov 10
Mon, Nov 9
Sun, Nov 8
Sat, Nov 7
May 16 2020
Apr 25 2018
Apr 24 2018
Apr 4 2018
LGTM - can you commit?
Apr 3 2018
Thanks for working on this fairly embarrassing bug (let's fix this before the week is over :)
Mar 14 2018
I discussed this briefly w Hubert - and i'm planning on modifying this patch slightly so that it flows through ParseDeclSpecifier and handles attributes and other invalid decl-specifiers such as static etc. more gracefully on a concept decl. I have this partially implemented - my hope is to get this done v soonish so feel free to ping me if you don't hear anything about this in a week or so ...
Jan 1 2018
Dec 31 2017
Dec 30 2017
Dec 29 2017
Dec 28 2017
Dec 27 2017
Dec 25 2017
Dec 24 2017
I think this looks good enough to commit - do you have commit privileges - or do you need one of us to commit it for you?
Dec 23 2017
Dec 21 2017
Added via https://reviews.llvm.org/rC321339
Dec 20 2017
Miyuki - please take a look at the patch and let me know if you agree with the changes - or have any concerns...
Sounds good - if I don't get this done over the next seven days - would you mind just pinging me!
Dec 19 2017
Hmm - I think i might make some tweaks to this patch (to be largely symmetric with the similar handling of invalid decl-specifiers on function parameters in Sema::Actions.ActOnParamDeclarator)...
Dec 17 2017
Otherwise, I think this looks good enough to commit.
Thanks for working on this! :)
Dec 16 2017
Dec 1 2017
Nov 11 2017
Just added an additional bit-field to FunctionDecl in https://reviews.llvm.org/rL317984
Oct 25 2017
Incorporated Aaron's feedback (although not sure if I caugh tall the white space issues).
Oct 22 2017
Oct 15 2017
committed as r315840.