Page MenuHomePhabricator

[SimplifyCFG] Also use the SwitchReduceRange Threshold for shift operations.
AbandonedPublic

Authored by shawnl on Jun 12 2019, 9:52 PM.

Details

Reviewers
jmolloy
nikic
Summary

There is a test that happens to want it this way

CodeGen/Thumb2/constant-islands-jump-table.ll

I did the full llvm test suite with this, on ppc64le and x86_64.

On top of D61237 and D61159 (which went in and then were reverted)

The idea is to put both in at the same time, so the test suite passes, but the build never breaks.

D62465 is this same commit

Diff Detail

Event Timeline

shawnl created this revision.Jun 12 2019, 9:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2019, 9:52 PM
shawnl edited the summary of this revision. (Show Details)Jun 12 2019, 9:53 PM
shawnl edited the summary of this revision. (Show Details)Jun 12 2019, 10:05 PM
shawnl updated this revision to Diff 204668.EditedJun 13 2019, 5:15 PM

fix tests when building tests for ALL architectures

there is one very small regression here, that a test checks for, (the three patches are together in terms of passing tests) where an unnecessary subtraction is added (and in a very few cases), but patches I have already written take care of this, so I don't think it is a big deal.

shawnl abandoned this revision.Jun 25 2020, 2:03 AM