Page MenuHomePhabricator

[SimplifyCFG] Also using the SwitchReduceRange Threshold for shift operations.
AbandonedPublic

Authored by shawnl on May 26 2019, 8:45 AM.

Details

Reviewers
nikic
jmolloy
Summary

There is a test that happens to want it this way

CodeGen/Thumb2/constant-islands-jump-table.ll

Diff Detail

Event Timeline

shawnl created this revision.May 26 2019, 8:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2019, 8:45 AM
shawnl planned changes to this revision.May 26 2019, 8:47 AM

this should use saturating multiplication

shawnl updated this revision to Diff 201451.May 26 2019, 8:48 AM

use saturating multiply

Before we go any further here, I'd suggest to revert all the switch related changes that have landed for now. They've had a lot of test fallout, and it looks like they broke the ubsan (and msan and asan) builders (see e.g. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/13084) in a way that looks like a miscompile of the clang bootstrap to me. Hard to tell which change exactly is at fault as multiple were pushed at the same time. As such I'd suggest to revert back to a green build and then reapply changes more carefully, such that tests pass for each individual commit.

Yes, can you revert them. I really am not very skilled with svn.