This is an archive of the discontinued LLVM Phabricator instance.

CMake: Set HOST_LINK_VERSION on Darwin (PR21268)
ClosedPublic

Authored by hans on Nov 12 2014, 3:38 PM.

Details

Reviewers
thakis
Summary

The Autoconf build already does this, but it was never ported to CMake. The host linker version affects the flags that Clang pass to the linker, notably whether it passes -demangle or not.

Diff Detail

Event Timeline

hans updated this revision to Diff 16120.Nov 12 2014, 3:38 PM
hans retitled this revision from to CMake: Set HOST_LINK_VERSION on Darwin (PR21268).
hans updated this object.
hans edited the test plan for this revision. (Show Details)
hans added a reviewer: thakis.
hans added subscribers: Unknown Object (MLST), hansw.
thakis accepted this revision.Nov 12 2014, 4:13 PM
thakis edited edge metadata.

Looks good as far as I can tell, thanks.

(Should there be some OS X-only test that checks if the frontend passes -demangle to the linker?)

This revision is now accepted and ready to land.Nov 12 2014, 4:13 PM
thakis closed this revision.Jan 27 2015, 9:47 AM

r221844