Donot use -std=libstdc++ option if $(CC)=cc.

[sivachandra]

Summary

After D6199 (http://reviews.llvm.org/D6199) landed, this test is
erroring out because of incompatible -std=libstdc++ when building on stock
Ubuntu.

[emaste]

Let me see if I follow,

Previously we appended -stdlib=libstdc++ for icc and clang, not for gcc (and we never set CC=cc)
Now we append -stdlib=libstdc++ for icc and clang, and not for gcc or cc

I think this is fine as far as fixing the Ubuntu failure.

On FreeBSD if we find cc it will be clang though, so that will be a new issue.

How does -stdlib=libstdc++ fail on Ubuntu?

[sivachandra]

Sorry for the delay, I missed this somehow.

So, when c++ is g++ (as is the case on Ubuntu), it will not recognize the -stdlib=libstdc++ option. Now since you say that cc is actually clang on FreeBSD, I do not think my patch is correct.

[emaste]

Do we still want to do something here?

test/functionalities/data-formatter/data-formatter-skip-summary/Makefile

 LEVEL = ../../../make
 
 CXX_SOURCES := main.cpp
 
 include $(LEVEL)/Makefile.rules
 
 CXXFLAGS += -O0
 
-ifeq (,$(findstring gcc,$(CC)))
+ifneq (cc, $(findstring cc, $(CC)))
 CXXFLAGS += -stdlib=libstdc++
 LDFLAGS += -stdlib=libstdc++
+else
+  ifeq (icc, $(findstring icc, $(CC)))
+    CXXFLAGS += -stdlib=libstdc++
+    LDFLAGS += -stdlib=libstdc++
+  endif
 endif