This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj] Support AArch64 relocations.
ClosedPublic

Authored by stewartd on Nov 10 2014, 7:12 AM.

Details

Summary

This adds support for AArch64 relocation types. The supplied test is there to ensure that an AArch64 relocation type is recognized.

Diff Detail

Event Timeline

stewartd updated this revision to Diff 15976.Nov 10 2014, 7:12 AM
stewartd retitled this revision from to [yaml2obj] Support AArch64 relocations..
stewartd updated this object.
stewartd edited the test plan for this revision. (Show Details)
stewartd added a project: lld.
stewartd added a subscriber: Unknown Object (MLST).
shankarke added inline comments.
test/Object/AArch64/yaml2obj-elf-aarch64-rel.yaml
26–27

While the ABI says AARCH64 can have .rel/.rela relocation records, rela is what is consistently used. I think we should stick to .rela in the test as well.

Aside that, is there a way to check that the yaml2obj can check for the type of relocation records thats emitted by the tool ? If so I think it would be nice to have the feature as well.

stewartd updated this revision to Diff 16003.Nov 10 2014, 11:49 AM

Updated the test to use rela.

shankarke accepted this revision.Nov 10 2014, 12:03 PM
shankarke added a reviewer: shankarke.
This revision is now accepted and ready to land.Nov 10 2014, 12:03 PM
atanasyan accepted this revision.Nov 10 2014, 12:06 PM
atanasyan edited edge metadata.

LGTM

mcrosier closed this revision.Nov 10 2014, 2:54 PM
mcrosier added a subscriber: mcrosier.

Committed in r221639.