This is an archive of the discontinued LLVM Phabricator instance.

Fix ubsan error in ValueMap
AbandonedPublic

Authored by arsenm on Nov 6 2014, 1:27 PM.

Download Raw Diff

Details

Reviewers

Summary

Fixes "llvm/IR/ValueMap.h:210:65: runtime error: upcast of misaligned address 0xfffffffffffffffc for type 'llvm::AllocaInst', which requires 8 byte alignment
0xfffffffffffffffc: note: pointer points here"

Diff Detail

Event Timeline

arsenm updated this revision to Diff 15890.Nov 6 2014, 1:27 PM

arsenm retitled this revision from to Fix ubsan error in ValueMap.

arsenm updated this object.

arsenm edited the test plan for this revision. (Show Details)

arsenm added a reviewer: rsmith.

arsenm added a subscriber: Unknown Object (MLST).

ping

How about adding a private ValueMapCallbackVH constructor, that takes a single llvm::Value *. It would be only used to create "fake" ValueMapCallbackVH for empty/tombstone keys in DenseMapInfo<>.

Losing compile-time check that static_cast<> enforces would be unfortunate.

This appear to be obsoleted by D6903

Revision Contents

Path

Size

include/

llvm/

IR/

ValueMap.h

2 lines

Diff 15890

include/llvm/IR/ValueMap.h

Context not available.
	ValueMapT *Map;	ValueMapT *Map;

	ValueMapCallbackVH(KeyT Key, ValueMapT *Map)	ValueMapCallbackVH(KeyT Key, ValueMapT *Map)
	: CallbackVH(const_cast<Value>(static_cast<const Value>(Key))),	: CallbackVH(const_cast<Value>(reinterpret_cast<const Value>(Key))),
	Map(Map) {}	Map(Map) {}

	public:	public:
Context not available.