Details
Diff Detail
Event Timeline
test/ubsan/lit.common.cfg | ||
---|---|---|
50 | This comment is identical to the test that immediately follows so seems redundant. Perhaps: # Check that the host supports UndefinedBehaviorSanitizer if config.host_os not in ... |
Sure, feel free to submit it once you fix the other stuff.
test/ubsan/lit.common.cfg | ||
---|---|---|
50 | Or just delete this comment, the statement seems simple enough. |
test/ubsan/lit.common.cfg | ||
---|---|---|
50 | The comment itself looks to be useful as it refers to UndefinedBehaviorSanitizer tests explicitly while the code does not, but I agree that there's little sense in duplicating the list of supported platforms. I will follow the Ed's proposal, if there are no objections. Thanks. |
This comment is identical to the test that immediately follows so seems redundant.
Perhaps: