This is an archive of the discontinued LLVM Phabricator instance.

Enable running Ubsan tests on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Nov 3 2014, 7:35 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to Enable running Ubsan tests on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
emaste added inline comments.Nov 3 2014, 8:19 AM
test/ubsan/lit.common.cfg
50 ↗(On Diff #15710)

This comment is identical to the test that immediately follows so seems redundant.

Perhaps:

# Check that the host supports UndefinedBehaviorSanitizer
if config.host_os not in ...
samsonov accepted this revision.Nov 3 2014, 11:24 AM
samsonov edited edge metadata.

Sure, feel free to submit it once you fix the other stuff.

test/ubsan/lit.common.cfg
50 ↗(On Diff #15710)

Or just delete this comment, the statement seems simple enough.

This revision is now accepted and ready to land.Nov 3 2014, 11:24 AM
test/ubsan/lit.common.cfg
50 ↗(On Diff #15710)

The comment itself looks to be useful as it refers to UndefinedBehaviorSanitizer tests explicitly while the code does not, but I agree that there's little sense in duplicating the list of supported platforms. I will follow the Ed's proposal, if there are no objections. Thanks.

Diffusion closed this revision.Nov 10 2014, 7:23 AM
Diffusion updated this revision to Diff 15980.

Closed by commit rL221599 (authored by vkutuzov).