Page MenuHomePhabricator

Pass aggregate arguments by value in NVPTX
ClosedPublic

Authored by jpienaar on Oct 28 2014, 5:31 PM.

Details

Summary

Following the NVVM IR specifications, arguments of aggregate type should be passed on the stack without splitting (byval).

Diff Detail

Event Timeline

jpienaar updated this revision to Diff 15534.Oct 28 2014, 5:31 PM
jpienaar retitled this revision from to Pass aggregate arguments by value in NVPTX.
jpienaar updated this object.
jpienaar edited the test plan for this revision. (Show Details)
jpienaar added a reviewer: eliben.
jpienaar added a subscriber: Unknown Object (MLST).
eliben added inline comments.Oct 28 2014, 5:39 PM
test/CodeGen/nvptx-abi.c
9

Makes sense to put a CHECK-LABEL here too?

jpienaar updated this revision to Diff 15535.Oct 28 2014, 5:43 PM

Added CHECK-LABEL to myfunction

jholewinski accepted this revision.Oct 29 2014, 5:49 AM
jholewinski edited edge metadata.

LGTM. Thanks!

This revision is now accepted and ready to land.Oct 29 2014, 5:49 AM
eliben accepted this revision.Oct 29 2014, 6:54 AM
eliben edited edge metadata.

Committed with a small test fix in r220854

Justin - thanks for the quick review