This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Mark most tuple tests UNSUPPORTED for c++03 and c++98.
ClosedPublic

Authored by EricWF on Oct 23 2014, 8:16 PM.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 15376.Oct 23 2014, 8:16 PM
EricWF retitled this revision from to [libcxx] Mark most tuple tests UNSUPPORTED for c++03 and c++98..
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added reviewers: mclow.lists, danalbert, jroelofs.
EricWF added a subscriber: Unknown Object (MLST).
jroelofs added inline comments.Oct 27 2014, 3:11 PM
test/utilities/tuple/tuple.general/tuple.smartptr.pass.cpp
11 ↗(On Diff #15376)

Don't we require that the set of LIT directives happen in the first continuous block of '//' comments?

EricWF added inline comments.Oct 27 2014, 3:55 PM
test/utilities/tuple/tuple.general/tuple.smartptr.pass.cpp
11 ↗(On Diff #15376)

Almost. Lines containing only white space are also allowed.

jroelofs added inline comments.Oct 27 2014, 3:57 PM
test/utilities/tuple/tuple.general/tuple.smartptr.pass.cpp
11 ↗(On Diff #15376)

Ah. Awkward. Why don't we allow it throughout the whole file?

N

test/utilities/tuple/tuple.general/tuple.smartptr.pass.cpp
11 ↗(On Diff #15376)

Not sure. There has never been a need to do that. Perhaps to enforce the style that these comments go at the top?

danalbert accepted this revision.Dec 16 2014, 6:09 PM
danalbert edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Dec 16 2014, 6:09 PM
mclow.lists edited edge metadata.EditedDec 17 2014, 5:16 PM

Do we actually care about C++98?
[ Other than that, LGTM ]

Do we actually care about C++98?

It's the default compilation mode for g++ (well, gnu++98 is anyway), so definitely worth testing against.

I think I'm coming around to @danalbert's way of thinking. Shouldn't these be XFAIL instead?

EricWF updated this revision to Diff 20247.Feb 18 2015, 6:00 PM
EricWF edited edge metadata.

Rebase against ToT.

EricWF updated this revision to Diff 20249.Feb 18 2015, 6:09 PM

Remove unsupported markings from some of the tests.

EricWF closed this revision.Feb 18 2015, 6:12 PM