This is an archive of the discontinued LLVM Phabricator instance.

Do not add -gsplit-dwarf to LLVM_DEFINITIONS.
ClosedPublic

Authored by pcc on Oct 21 2014, 3:10 PM.

Details

Summary

This would cause the flag to appear in the output of "llvm-config --cppflags",
which should contain only preprocessor flags. The -gsplit-dwarf flag in
particular can cause problems with certain downstream users such as cgo.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 15216.Oct 21 2014, 3:10 PM
pcc retitled this revision from to Do not add -gsplit-dwarf to LLVM_DEFINITIONS..
pcc updated this object.
pcc edited the test plan for this revision. (Show Details)
pcc added a reviewer: dblaikie.
pcc added subscribers: echristo, Unknown Object (MLST).
dblaikie accepted this revision.Oct 22 2014, 12:41 PM
dblaikie edited edge metadata.

Works for me

This revision is now accepted and ready to land.Oct 22 2014, 12:41 PM
pcc closed this revision.Oct 22 2014, 12:59 PM
pcc updated this revision to Diff 15272.

Closed by commit rL220410 (authored by @pcc).