Fix swig interface for SBTarget.Launch

[zephyr]

Summary

Launch has two overloaded versions. One version has list type, which
cannot be handled properly by swig.

This patch renames Launch(SBLaunchInfo&, SBError&) to Launch2.

[mg11]

Two initial comments:

1. applying the diff failed for me:

$ patch -p0 <D5878.diff
patching file scripts/Python/interface/SBTarget.i
Hunk #1 succeeded at 279 with fuzz 2 (offset -146 lines).
patching file test/api/multiple-debuggers/multi-process-driver.cpp
patching file test/python_api/event/TestEvents.py
Hunk #1 FAILED at 161.
Hunk #2 FAILED at 229.
2 out of 2 hunks FAILED -- saving rejects to file test/python_api/event/TestEvents.py.rej
patching file test/python_api/process/io/TestProcessIO.py
patching file test/python_api/target/TestTargetAPI.py

Could you re generate this diff please?

2. Could you use a more descriptive name than Launch2 please?

[jasonmolenda]

I didn't see Enrico's comment show up in this reviews.llvm.org record - but is this change still needed after his fix in r220306?

[granata.enrico]

In D5878#5, @jasonmolenda wrote:

I didn't see Enrico's comment show up in this reviews.llvm.org record - but is this change still needed after his fix in r220306?

Hopefully not. The original repro case worked for me after landing r220306

[zephyr]

Hi Enrico,

You patch is the right fix. I works for me.

Thanks!

scripts/Python/interface/SBTarget.i

                   const char **envp,
                   const char *working_directory);
 
+    %rename(Launch2) Launch;
     lldb::SBProcess
     Launch (lldb::SBLaunchInfo &launch_info, lldb::SBError& error);
 

test/api/multiple-debuggers/multi-process-driver.cpp

 
             SBLaunchInfo launch_info (NULL);
             SBError error;
-            SBProcess process = target.Launch (launch_info, error);
+            SBProcess process = target.Launch2 (launch_info, error);
             if (process.IsValid())
             {
                 SBListener listener = debugger.GetListener();

test/python_api/event/TestEvents.py

         # Now launch the process, and do not stop at entry point.
         error = lldb.SBError()
         process = target.Launch (listener,
-                                 None,      # argv
+                                 ['a','b'], # argv
                                  None,      # envp
                                  None,      # stdin_path
                                  None,      # stdout_path

         # Now launch the process, and do not stop at the entry point.
         error = lldb.SBError()
         process = target.Launch (listener,
-                                 None,      # argv
+                                 ['a','b'], # argv
                                  None,      # envp
                                  None,      # stdin_path
                                  None,      # stdout_path

test/python_api/process/io/TestProcessIO.py

         error = lldb.SBError()
         # This should launch the process and it should exit by the time we get back
         # because we have synchronous mode enabled
-        self.process = self.target.Launch (self.launch_info, error)
+        self.process = self.target.Launch2 (self.launch_info, error)
 
         self.assertTrue(error.Success(), "Make sure process launched successfully")
         self.assertTrue(self.process, PROCESS_IS_VALID)

test/python_api/target/TestTargetAPI.py

         # Now launch the process, do not stop at entry point, and redirect stdout to "stdout.txt" file.
         # The inferior should run to completion after "process.Continue()" call.
         error = lldb.SBError()
-        process = target.Launch (self.dbg.GetListener(), None, None, None, "stdout.txt", None, None, 0, False, error)
+        process = target.Launch2 (self.dbg.GetListener(), None, None, None, "stdout.txt", None, None, 0, False, error)
         process.Continue()
         #self.runCmd("process status")