Don't use mkstemp, as it doesn't exist on Windows.

[zturner]

Summary

mkstemp doesn't exist on Windows. A function is provided by LLVM support libraries for this reason, so use that instead.

[jasonmolenda]

Thanks Zachary. Please commit.

[zturner]

Closed by commit rL220218 (authored by @zturner).

lldb/trunk/source/Expression/ClangExpressionParser.cpp

ClangExpressionParser::Parse (Stream &stream)
     const char *expr_text = m_expr.Text();
 
     clang::SourceManager &SourceMgr = m_compiler->getSourceManager();
     bool created_main_file = false;
     if (m_compiler->getCodeGenOpts().getDebugInfo() == CodeGenOptions::FullDebugInfo)
     {
         std::string temp_source_path;
 
+        int temp_fd = -1;
+        llvm::SmallString<PATH_MAX> result_path;
         FileSpec tmpdir_file_spec;
         if (HostInfo::GetLLDBPath(lldb::ePathTypeLLDBTempSystemDir, tmpdir_file_spec))
         {
-            tmpdir_file_spec.AppendPathComponent("expr.XXXXXX");
+            tmpdir_file_spec.AppendPathComponent("lldb-%%%%%%.expr");
             temp_source_path = std::move(tmpdir_file_spec.GetPath());
+            llvm::sys::fs::createUniqueFile(temp_source_path, temp_fd, result_path);
         }
         else
         {
-            temp_source_path = "/tmp/expr.XXXXXX";
+            llvm::sys::fs::createTemporaryFile("lldb", "expr", temp_fd, result_path);
         }
         
-        int temp_fd = ::mkstemp(&temp_source_path[0]);
-        
         if (temp_fd != -1)
         {
             lldb_private::File file (temp_fd, true);
             const size_t expr_text_len = strlen(expr_text);
             size_t bytes_written = expr_text_len;
             if (file.Write(expr_text, bytes_written).Success())
             {
                 if (bytes_written == expr_text_len)
                 {
                     file.Close();
                     SourceMgr.setMainFileID(SourceMgr.createFileID(
-                        m_file_manager->getFile(temp_source_path),
+                        m_file_manager->getFile(result_path),
                         SourceLocation(), SrcMgr::C_User));
                     created_main_file = true;
                 }
             }
         }
     }
 
     if (!created_main_file)