This is an archive of the discontinued LLVM Phabricator instance.

Fix code to follow the "Don’t use else after a return" rule.
ClosedPublic

Authored by sbenza on Oct 16 2014, 7:54 AM.

Diff Detail

Event Timeline

sbenza updated this revision to Diff 15018.Oct 16 2014, 7:54 AM
sbenza retitled this revision from to Fix code to follow the "Don’t use else after a return" rule..
sbenza updated this object.
sbenza edited the test plan for this revision. (Show Details)
sbenza added a reviewer: alexfh.
sbenza added a subscriber: Unknown Object (MLST).
rafael accepted this revision.Oct 16 2014, 8:01 AM
rafael added a reviewer: rafael.
rafael added a subscriber: rafael.

LGTM with a nit.

lib/ASTMatchers/ASTMatchersInternal.cpp
252–253

You can drop the {} too now.

This revision is now accepted and ready to land.Oct 16 2014, 8:01 AM
alexfh accepted this revision.Oct 16 2014, 8:30 AM
alexfh edited edge metadata.

LG

sbenza updated this revision to Diff 15024.Oct 16 2014, 9:30 AM
sbenza edited edge metadata.

Remove unnecessary {}

sbenza closed this revision.Oct 16 2014, 11:00 AM
sbenza updated this revision to Diff 15029.

Closed by commit rL219939 (authored by @sbenza).