This is an archive of the discontinued LLVM Phabricator instance.

Fix typo in Clang test arm-cortex-cpus.c
ClosedPublic

Authored by enefaim on Oct 16 2014, 6:05 AM.

Download Raw Diff

Details

Reviewers

rengolin
jmolloy
bogden

Summary

There is a typo in Driver/arm-cortex-cpus.c using 'armv' as target instead of 'arm'.

Diff Detail

Event Timeline

enefaim updated this revision to Diff 15014.Oct 16 2014, 6:05 AM

enefaim retitled this revision from to Fix typo in Clang test arm-cortex-cpus.c.

enefaim updated this object.

enefaim edited the test plan for this revision. (Show Details)

enefaim added reviewers: bogden, rengolin.

enefaim added subscribers: Unknown Object (MLST), Unknown Object (MLST).

Herald added a subscriber: aemerson. · View Herald TranscriptOct 16 2014, 6:05 AM

I am working on a patch that accepts only existing subtarget names in the triple.
Right now every string that starts with armv, armebv, thumbv or thumbebv is accepted.
This test failed with my work-in-progress patch.

LGTM!

This revision is now accepted and ready to land.Oct 16 2014, 8:05 AM

Hi James,
Thanks for the review. Could you land the patch for me?
I don't have commit rights.

rengolin closed this revision.Oct 22 2014, 7:01 AM

Revision Contents

Path

Size

test/

Driver/

arm-cortex-cpus.c

2 lines

Diff 15014

test/Driver/arm-cortex-cpus.c

	// ================== Check default CPU on each major architecture			// ================== Check default CPU on each major architecture
	// RUN: %clang -target armv4t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V4T %s			// RUN: %clang -target armv4t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V4T %s
	// RUN: %clang -target arm -march=armv4t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V4T %s			// RUN: %clang -target arm -march=armv4t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V4T %s
	// CHECK-V4T: "-cc1"{{.}} "-triple" "armv4t-{{.}} "-target-cpu" "arm7tdmi"			// CHECK-V4T: "-cc1"{{.}} "-triple" "armv4t-{{.}} "-target-cpu" "arm7tdmi"

	// RUN: %clang -target armv4t -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V4T-THUMB %s			// RUN: %clang -target armv4t -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V4T-THUMB %s
	// RUN: %clang -target arm -mthumb -march=armv4t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V4T-THUMB %s			// RUN: %clang -target arm -mthumb -march=armv4t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V4T-THUMB %s
	// CHECK-V4T-THUMB: "-cc1"{{.}} "-triple" "thumbv4t-{{.}} "-target-cpu" "arm7tdmi"			// CHECK-V4T-THUMB: "-cc1"{{.}} "-triple" "thumbv4t-{{.}} "-target-cpu" "arm7tdmi"

	// RUN: %clang -target armv5 -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5 %s			// RUN: %clang -target armv5 -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5 %s
	// RUN: %clang -target arm -march=armv5 -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5 %s			// RUN: %clang -target arm -march=armv5 -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5 %s
	// RUN: %clang -target armv5t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5 %s			// RUN: %clang -target armv5t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5 %s
	// RUN: %clang -target arm -march=armv5t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5 %s			// RUN: %clang -target arm -march=armv5t -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5 %s
	// CHECK-V5: "-cc1"{{.}} "-triple" "armv5-{{.}} "-target-cpu" "arm10tdmi"			// CHECK-V5: "-cc1"{{.}} "-triple" "armv5-{{.}} "-target-cpu" "arm10tdmi"

	// RUN: %clang -target armv5 -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5-THUMB %s			// RUN: %clang -target armv5 -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5-THUMB %s
	// RUN: %clang -target armv -march=armv5 -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5-THUMB %s			// RUN: %clang -target arm -march=armv5 -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5-THUMB %s
	// RUN: %clang -target armv5t -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5-THUMB %s			// RUN: %clang -target armv5t -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5-THUMB %s
	// RUN: %clang -target arm -march=armv5 -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5-THUMB %s			// RUN: %clang -target arm -march=armv5 -mthumb -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5-THUMB %s
	// CHECK-V5-THUMB: "-cc1"{{.}} "-triple" "thumbv5-{{.}} "-target-cpu" "arm10tdmi"			// CHECK-V5-THUMB: "-cc1"{{.}} "-triple" "thumbv5-{{.}} "-target-cpu" "arm10tdmi"

	// RUN: %clang -target armv5e -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5E %s			// RUN: %clang -target armv5e -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5E %s
	// RUN: %clang -target arm -march=armv5e -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5E %s			// RUN: %clang -target arm -march=armv5e -### -c %s 2>&1 \| FileCheck -check-prefix=CHECK-V5E %s
	// CHECK-V5E: "-cc1"{{.}} "-triple" "armv5e-{{.}} "-target-cpu" "arm1022e"			// CHECK-V5E: "-cc1"{{.}} "-triple" "armv5e-{{.}} "-target-cpu" "arm1022e"

	▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines