This is an archive of the discontinued LLVM Phabricator instance.

Adds stable-runtime to ubsan to avoid broken ARM tests with asan
ClosedPublic

Authored by rengolin on Oct 15 2014, 3:35 AM.

Download Raw Diff

Details

Reviewers

rengolin
samsonov
eugenis

Summary

I haven't tested this, just want to make sure that's what you meant to disable the test altogether instead of XFAIL.

The problem with testing is that I use a different hardware on the bot that I have for testing (no NEON, different OS), and things fail differently here and there. Actually, on my test bot things stopped failing a while ago, but on the bot we still have that kind of bugs.

Basically, I'm trying to move the same logic we use in ASAN to UBSAN, so we can avoid them in the same way. Will just adding the lit.cfg be enough to make the option available to the test case?

Diff Detail

Event Timeline

rengolin updated this revision to Diff 14917.Oct 15 2014, 3:35 AM

rengolin retitled this revision from to Adds stable-runtime to ubsan to avoid broken ARM tests with asan.

rengolin updated this object.

rengolin edited the test plan for this revision. (Show Details)

rengolin added a reviewer: eugenis.

rengolin set the repository for this revision to rL LLVM.

rengolin added subscribers: Unknown Object (MLST), kcc.

Herald added a subscriber: aemerson. · View Herald TranscriptOct 15 2014, 3:35 AM

samsonov added a reviewer: samsonov.Oct 15 2014, 11:22 AM

samsonov added a subscriber: samsonov.

samsonov added inline comments.

test/ubsan/lit.cfg
8	Add this piece to the end of test/ubsan/lit.common.cfg instead.

rengolin added inline comments.Oct 15 2014, 3:30 PM

test/ubsan/lit.cfg
8	I was wondering if they were interchangeable. Will do that, thanks!

It worked! :)

Thanks

This revision is now accepted and ready to land.Oct 16 2014, 6:34 AM

rengolin closed this revision.Oct 16 2014, 6:34 AM

Revision Contents

Path

Size

test/

ubsan/

TestCases/

TypeCheck/

vptr.cpp

1 line

lit.cfg

9 lines

Diff 14917

test/ubsan/TestCases/TypeCheck/vptr.cpp

Context not available.

	// FIXME: This test produces linker errors on Darwin.	// FIXME: This test produces linker errors on Darwin.
	// XFAIL: darwin	// XFAIL: darwin
		// REQUIRES: stable-runtime

	extern "C" {	extern "C" {
	const char *__ubsan_default_options() {	const char *__ubsan_default_options() {
Context not available.

test/ubsan/lit.cfg

This file was added.

				# -- Python --

				import os
				import platform

				# Allow tests to use REQUIRES=stable-runtime. For use when you cannot use XFAIL
				# because the test hangs.
				if config.target_arch != 'arm':
				samsonovUnsubmitted Not Done Reply Inline Actions Add this piece to the end of test/ubsan/lit.common.cfg instead. samsonov: Add this piece to the end of test/ubsan/lit.common.cfg instead.
				rengolinAuthorUnsubmitted Not Done Reply Inline Actions I was wondering if they were interchangeable. Will do that, thanks! rengolin: I was wondering if they were interchangeable. Will do that, thanks!
				config.available_features.add('stable-runtime')