This is an archive of the discontinued LLVM Phabricator instance.

[mips] Add support for COP0's Branch-On-Cond-Likely instructions
ClosedPublic

Authored by vkalintiris on Oct 14 2014, 1:03 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

vkalintiris retitled this revision from to [mips] Add support for COP0's Branch-On-Cond-Likely instructions.
vkalintiris updated this object.
vkalintiris edited the test plan for this revision. (Show Details)
vkalintiris added a reviewer: dsanders.
vkalintiris added a subscriber: Unknown Object (MLST).
dsanders accepted this revision.Oct 17 2014, 2:21 AM
dsanders edited edge metadata.

LGTM with hasDelaySlot=0

lib/Target/Mips/MipsInstrInfo.td
1197–1198 ↗(On Diff #14885)

hasDelaySlot needs to be 0 but CBranch sets it to 1.

This revision is now accepted and ready to land.Oct 17 2014, 2:21 AM
vkalintiris added inline comments.Oct 17 2014, 3:55 AM
lib/Target/Mips/MipsInstrInfo.td
1230–1231 ↗(On Diff #14885)

I will change the hasDelaySlot field for this likely instruction too since BGEZAL_FT sets it to 1.

1234–1235 ↗(On Diff #14885)

I will change the hasDelaySlot field for this likely instruction too since BGEZAL_FT sets it to 1.

vkalintiris closed this revision.Oct 17 2014, 5:49 AM
vkalintiris updated this revision to Diff 15071.

Closed by commit rL220036 (authored by @vkalintiris).